You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.
The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?
But there is the concern as @fengyuentau mentioned earlier:
The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?
But there is the concern as @fengyuentau mentioned earlier:
The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?
I'm sorry to inform you that currently, on MacOS, the Orbbec camera can only be implemented using this method.
The reason will be displayed to describe this comment to others. Learn more.
👍 I propose to merge it for now and there should be a subsequent PR providing another build option which detects and uses the pre-installed libOrbbec instead of downloading it every time.
@asmorkalov I see that you haven't raised any new questions for a long time, and all the issues you previously raised have been resolved. We hope the code can be merged as soon as possible. Thank you.
Looks good for me in general, besides minor remarks. CMake option to point external Orbbec SDK is required, but it could be done in dedicated PR as proposed.
Orbbec Camera supports MacOS,Gemini2 and Gemini2L support Y16 format opencv#24877
note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.