| CARVIEW |
Select Language
HTTP/2 302
date: Thu, 24 Jul 2025 10:10:18 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/24873
server-timing: nginx;desc="NGINX";dur=1.148832,glb;desc="GLB";dur=100.731862
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=xDNJnaaoh8QF4lRqAMpmGv%2FE2GBu5z3Ikf0SXwyb9pUuHDpCEL2WNvsBaeaZ9BawjoLjxlMYbFKUTT8XgL230mipHCjrhNu5XqCWdvUYcdc6zY1OhK9WbvG4K3kfVUUryrljZ5tXN68MFwe%2FWwkvoTDHvvhvfl%2FwIVkBMNc1MXpQoOVjNAgO%2BrpbB1%2BY0ueatW1Q4c9X4fcGfUbmPBnTpeOiZtS6arLQJAomF12TignWJuApNmVEwsdLa7u5vJUspmmt4fn3sh7iAFOD%2FGjzQw%3D%3D--WKn7zbML8mgROWen--GI0jVlmu%2BWYwz0Y8QIHUmQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.654508084.1753351817; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 10:10:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 10:10:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E9DA:35B563:1872BFB:1D340C2:68820689
HTTP/2 200
date: Thu, 24 Jul 2025 10:10:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=394.994755,conversation_content-fragment;desc="conversation_content fragment";dur=884.382941,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=320.217428,nginx;desc="NGINX";dur=1.147572,glb;desc="GLB";dur=101.085678
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E9DA:35B563:1872C87:1D34188:68820689
Fix generateImage for charuco chessboard by AleksandrPanov · Pull Request #24873 · opencv/opencv · GitHub
AleksandrPanov
changed the title
fix generateImage for charuco chessboard
Fix generateImage for charuco chessboard
Jan 16, 2024
AleksandrPanov
force-pushed
the
fix_charuco_board
branch
from
January 17, 2024 08:17
AleksandrPanov
force-pushed
the
fix_charuco_board
branch
from
January 23, 2024 10:45
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Fix generateImage for charuco chessboard #24873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrPanov
changed the title
asmorkalov
reviewed
Jan 17, 2024
AleksandrPanov
force-pushed
the
fix_charuco_board
branch
from
8be0bb6 to
a0bedf0
Compare
AleksandrPanov
force-pushed
the
fix_charuco_board
branch
from
a0bedf0 to
37c76b8
Compare
asmorkalov
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
đź‘Ť
Merged
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
May 31, 2024
fixed marker generation in charuco board #25673 When generating Charuco board markers in `generateImage()`, a problem occurs as in #24806, #24873: In low resolution:  In medium resolution:  This PR fixed this problems:   The test checks the inner and outer borders of the Aruco markers. In the outer border of Aruco marker, all pixels should be white. In the inner border of Aruco marker, all pixels should be black.  ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #24806
The problem was only if the size of the image is not completely divided by the size of the square of the chessboard.
Now the corners of the chessboard are generated as closely as possible with the values of getChessboardCorners(), and now the error (between chessboard corners) is no more than 0.5 pixels.
Before fix:
After fix:
There are still some problems with ArUco markers.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.