| CARVIEW |
Select Language
HTTP/2 302
date: Wed, 23 Jul 2025 05:08:45 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/24869
server-timing: nginx;desc="NGINX";dur=1.601423,glb;desc="GLB";dur=101.691304
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=5UVsn1pZvT5qLmgcwJUuLQGALDiXVTkK7TZSf7dqLZU7pRKELfEeGJFbLWFuhQklxBS58%2FgjmNzYoasw65ogrqgK3Zo%2BS5ibmxH6%2BPPSsWIXi9mnAaKdFuU3rEiCHkRZjUL19WJF96jSyYwQxZ0bUlOm4Q325nt%2BdxZ%2F7arkHhdxS%2BOy260Pm7Rl%2F6CBw1rYCt09vjy%2BP7bTAEA7oVzNQWDznwQIV4kx5b72%2FtIifQaGqIWk%2BbXAVAgC7NaAJaJRXMkvdJ6HDjjU%2FSgcNqoPPA%3D%3D--7kTe1%2BfAESj7ji8k--Af1JvefUgPfc7c%2FD8LWtgA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.672787706.1753247325; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 05:08:45 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 05:08:45 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E3EA:39062F:3C5A87:51AE07:68806E5D
HTTP/2 200
date: Wed, 23 Jul 2025 05:08:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=304.794569,conversation_content-fragment;desc="conversation_content fragment";dur=1119.156474,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=231.59915,nginx;desc="NGINX";dur=0.97729,glb;desc="GLB";dur=101.274242
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E3EA:39062F:3C5B10:51AEA2:68806E5D
Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization. by alexlyulkov · Pull Request #24869 · opencv/opencv · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization. #24869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 2 commits into
opencv:4.x
from
alexlyulkov:al/android-camera-view-rotate
Jan 17, 2024
Merged
Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization. #24869
asmorkalov
merged 2 commits into
opencv:4.x
from
alexlyulkov:al/android-camera-view-rotate
Jan 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fixed JavaCamera2View initialization
alexlyulkov
commented
Jan 16, 2024
| } | ||
|
|
||
| if (mFpsMeter != null) { | ||
| mFpsMeter.setResolution(mFrameWidth, mFrameHeight); | ||
| } | ||
|
|
||
| Log.i(LOGTAG, "Opening camera: " + mCameraID); | ||
| manager.openCamera(mCameraID, mStateCallback, mBackgroundHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved camera starting here, because preview size should be defined before camera start
| @@ -322,12 +332,16 @@ protected boolean connectCamera(int width, int height) { | |||
| mCaptureSession.close(); | |||
| mCaptureSession = null; | |||
| } | |||
| createCameraPreviewSession(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a createCameraPreviewSession call in onOpened camera callback.
asmorkalov
reviewed
Jan 17, 2024
modules/java/generator/android-21/java/org/opencv/android/JavaCamera2View.java
Show resolved
Hide resolved
|
@alexlyulkov I do not see preview with Pixel8 in Tutorial 4. Just black screen with text status in corner. |
|
Tutorial1-Camera-Preview works with all back-ends JavaCameraView, Java2CameraView and NativeCameraView with rotation. Please ignore the previous comment on Tutorial4. The sample does not work without the patch. It should be fixed separately. |
asmorkalov
reviewed
Jan 17, 2024
Comment on lines
129
to
131
| android.hardware.Camera.CameraInfo info = new android.hardware.Camera.CameraInfo(); | ||
| android.hardware.Camera.getCameraInfo(localCameraIndex, info); | ||
| int frameRotation = getFrameRotation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can re-use CameraInfo from cameras iteration when camera is selected.
modules/java/generator/android/java/org/opencv/android/JavaCameraView.java
Show resolved
Hide resolved
modules/java/generator/android-24/java/org/opencv/android/NativeCameraView.java
Show resolved
Hide resolved
asmorkalov
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
JStech
pushed a commit
to JStech/opencv
that referenced
this pull request
Jan 28, 2024
…ew-rotate Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization. opencv#24869 Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation. Fixed double preview initialization bug in JavaCamera2View. Added proper cameraID parsing to NativeCameraView similar to JavaCameraView ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation.
Fixed double preview initialization bug in JavaCamera2View.
Added proper cameraID parsing to NativeCameraView similar to JavaCameraView
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.