| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 09:12:26 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/24773
server-timing: nginx;desc="NGINX";dur=0.862678,glb;desc="GLB";dur=94.983565
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=pTPHAse4s0FCBSa3udF4fZkgh8VW42VPCKtytXgOyqCsAzvctrlcSirzwt6I9uRLR8B8iQvPQ9zWs6C0%2BeeIkF7auU7m9uBEUknLIH%2FM9jjWVRTaoWzu2wd7r%2FpylkYsM%2BNW0nlofv6iEYYBeQhKUwcNZva7gWinMW9JyFUniNEFZJomEGuJ5ZHeqCNy5otZKe1FRWFgftLq011nH2w14ahzqUWjA8CieG218mx6tKGO%2Bv5ezWVsJ%2FForLiikwThoJ3u8sZKN06LNzxY1qVlOw%3D%3D--judFD0wq9efhKtR5--ndFhZ7o%2FwnCFigvDa52trw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1533625376.1753089146; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:12:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:12:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9608:46557:180ADEE:1E7ED72:687E047A
HTTP/2 200
date: Mon, 21 Jul 2025 09:12:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=423.820339,conversation_content-fragment;desc="conversation_content fragment";dur=1074.696564,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=325.859635,nginx;desc="NGINX";dur=1.124605,glb;desc="GLB";dur=95.691496
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9608:46557:180AE6A:1E7EE00:687E047A
python: accept path-like objects wherever file names are expected by tailsu · Pull Request #24773 · opencv/opencv · GitHub
tailsu
force-pushed
the
sd/pathlike
branch
3 times, most recently
from
December 26, 2023 15:17
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
python: accept path-like objects wherever file names are expected #24773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tailsu
force-pushed
the
sd/pathlike
branch
3 times, most recently
from
22d7fb3 to
1bb2f2f
Compare
|
OpenCV team build OpenCV-Python package with Limited API option to reduce support matrix. The patch breaks it: |
|
Fix for the versioning issue of limited API: #24837 |
asmorkalov
reviewed
Jan 10, 2024
asmorkalov
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| @@ -701,6 +701,18 @@ bool pyopencv_to(PyObject* obj, String &value, const ArgInfo& info) | |||
| return true; | |||
| } | |||
| std::string str; | |||
|
|
|||
| #if ((PY_VERSION_HEX >= 0x03060000) && !defined(Py_LIMITED_API)) || (Py_LIMITED_API >= 0x03060000) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this check, because compilation fails in this configuration:
-- Python 3:
-- Interpreter: C:/utils/soft/python35-x64/python.exe (ver 3.5.4)
-- Libraries: C:/utils/soft/python35-x64/Libs/python35.lib (ver 3.5.4)
-- Limited API: YES (ver 0x03060000)
-- numpy: C:/utils/soft/python35-x64/lib/site-packages/numpy/core/include (ver 1.12.1)
-- install path: python/cv2/python-3
https://pullrequest.opencv.org/buildbot/builders/precommit_opencl/builds/100307
This was referenced Jan 15, 2024
Merged
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Merry Christmas, all 🎄
Implements #15731
Support is enabled for all arguments named
filenameorfilepath(case-insensitive), or annotated withCV_WRAP_FILE_PATH.Support is based on
PyOS_FSPath, which is available in Python 3.6+. When running on older Python versions the arguments must have astrvalue as before.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.