| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 15:59:51 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/24613
server-timing: nginx;desc="NGINX";dur=1.55086,glb;desc="GLB";dur=95.978762
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=eITlB4DfHz5cDZiX5Frye0PIWqvXazUnBdBKwDwovlfGAdANMP6vM%2F1UrCaLj7ThhSK9ei4ydisTf6jZZvVM8g9kYOGatJk9lRmzHGx0a6fT%2FlIz7ECI%2FOSiGXJQXUb%2FxVS5L2GGm5CWhydiFVD9iP2DK6Pl%2FQow4yCda1dBsAYtDttPadISjZQIxp1FGYiw5eSGR6If7WGE23cwr5hg82IcEHNU2Yb3iUPrfLuDpgAB8oHx8HOXedmXEdKkHzHoHbbjFws9SowS5WByri5cBQ%3D%3D--OgMWlnw8zaRfe%2FJ%2B--RkGL2kwIs7J1NTv2M5rZKA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1728287280.1753113591; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 15:59:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 15:59:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 89B4:67095:B5916:D42E1:687E63F7
HTTP/2 200
date: Mon, 21 Jul 2025 15:59:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=412.272275,conversation_content-fragment;desc="conversation_content fragment";dur=1262.841072,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=275.492489,nginx;desc="NGINX";dur=0.827146,glb;desc="GLB";dur=95.357073
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 89B4:67095:B596A:D4330:687E63F7
Make default axis of softmax in onnx "-1" without opset option by WanliZhong · Pull Request #24613 · opencv/opencv · GitHub
opencv-alalek
added
the
pr: needs test
New functionality requires minimal tests set
label
Nov 30, 2023
opencv-alalek
added
test
and removed
pr: needs test
New functionality requires minimal tests set
labels
Dec 15, 2023
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Make default axis of softmax in onnx "-1" without opset option #24613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuentau
reviewed
Nov 29, 2023
|
Not sure why always abi test failed. |
opencv-alalek
added
the
pr: needs test
|
@WanliZhong Could you push to the branch to trigger build once more. CI was broken the time you created the patch. My fault. |
|
@WanliZhong Could you add some test for the case or unlock some "conformance" test that covers it? |
|
@asmorkalov Thanks for comments. I will try it. |
|
|
yes, the failed CI have shown we can't modify the default axis to -1 in softmax layer. I propose just make this happen on onnx model. |
opencv-alalek
added
test
and removed
pr: needs test
dkurt
approved these changes
Dec 15, 2023
| @@ -2788,10 +2788,10 @@ void ONNXImporter::parseSoftMax(LayerParams& layerParams, const opencv_onnx::Nod | |||
| { | |||
| const std::string& layer_type = node_proto.op_type(); | |||
| int axis; | |||
| if (layerParams.has("opset") && layerParams.get<int>("opset") > 11) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update parseQSoftmax too? (may be in a separate PR?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try to change it in QSoftmax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create dedicated PR for parseQSoftmax.
fengyuentau
reviewed
Dec 15, 2023
fengyuentau
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Make default axis of softmax in onnx "-1" without opset option opencv#24613 Try to solve problem: opencv#24476 (comment) **ONNX** `opset <= 11` use 1 `else` use -1 **TensorFlow** `TF version = 2.x` use -1 `else` use 1 **Darknet, Caffe, Torch** use 1 by definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Try to solve problem: #24476 (comment)
ONNX
opset <= 11use 1elseuse -1TensorFlow
TF version = 2.xuse -1elseuse 1Darknet, Caffe, Torch
use 1 by definition