| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 15:58:36 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/24610
server-timing: nginx;desc="NGINX";dur=1.184723,glb;desc="GLB";dur=91.291681
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=JovEueqeftHCHcwUCTpcN1JD1iEe69OhhBoU3RQUNBDE3WfzZyj%2Bj%2BOPV%2BhKNwleyXsA%2BXC%2BQjvI%2BADGz4wFPRBCLN7362cwrOM3XugFefkS9zRvYKScnwEze3jGPv5wbnCVAYTsaPrt%2FkvrT7BKAjKyT%2B%2B0ez60swJsc5oUnyVA3Il4YYcPzIjIsNA6pt8klGxIqU3ORChhuRNIQO8l9VnBv6wBWtrhOLsJ76KFV3Z9RzAZLMNAwOZC%2FSTHh%2Bs7INOYQ3W3AcrxR200JNciWw%3D%3D--FcmpWSyOZbERr%2Bqx--JNMpEO9jlNTcrdK8rSRyqA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1684004728.1753113515; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 15:58:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 15:58:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D474:2708D1:B039C:CE325:687E63AB
HTTP/2 200
date: Mon, 21 Jul 2025 15:58:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=329.878062,conversation_content-fragment;desc="conversation_content fragment";dur=1514.26338,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=293.703266,nginx;desc="NGINX";dur=1.319167,glb;desc="GLB";dur=90.876157
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D474:2708D1:B03FF:CE392:687E63AB
dnn onnx: add group norm layer by jimmylaw21 · Pull Request #24610 · opencv/opencv · GitHub
jimmylaw21
force-pushed
the
dnn-onnx-add-group-norm-layer
branch
from
December 21, 2023 11:07
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
dnn onnx: add group norm layer #24610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 13 commits into
opencv:4.x
from
jimmylaw21:dnn-onnx-add-group-norm-layer
Jan 12, 2024
Merged
dnn onnx: add group norm layer #24610
asmorkalov
merged 13 commits into
opencv:4.x
from
jimmylaw21:dnn-onnx-add-group-norm-layer
Jan 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuentau
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to test your code:
- Make your test data and model. You can use the existing ONNX models and input data, but you should regenerate the outputs since their implementation is wrong.
- Fork opencv_extra, make a branch with the same branch name
dnn-onnx-add-group-norm-layer, upload the models and data to the branch and submit a PR to opencv_extra. Models should be put to$opencv_extra/testdata/dnn/onnx/conformance/node. Make sure you regenerate the ouput data files. Example: opencv/opencv_extra#1122. - Add tests in
modules/dnn/test/test_onnx_conformance.cpp. Example can be found here: https://github.com/opencv/opencv/pull/24544/files#diff-e5218dd7d4983b99874acb663bf3a849fca73572ae2d6da8083db8d08ee1433f.
|
Also you need to check the item: "I agree to contribute to the project under Apache 2 License." |
dkurt
reviewed
Nov 30, 2023
dkurt
reviewed
Nov 30, 2023
|
@fengyuentau @dkurt What are the next steps here? |
Seems like this PR cannot catch the release. Let me review this. |
fengyuentau
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve merge conflicts with the following commands:
git remote add upstream https://github.com/opencv/opencv
git fetch upstream
git rebase upstream/4.x
# Solve merge conflicts with your editor
git rebase --continue
git push -f
add group normalization impl
add testcases;revise group norm layer in response to [ONNX Issue #5466](onnx/onnx#5466)
jimmylaw21
force-pushed
the
dnn-onnx-add-group-norm-layer
branch
from
01090ae to
a321dac
Compare
fengyuentau
reviewed
Dec 21, 2023
dkurt
reviewed
Dec 22, 2023
fengyuentau
approved these changes
Dec 27, 2023
dkurt
reviewed
Dec 29, 2023
| @@ -311,6 +311,8 @@ static const TestCase testConformanceConfig[] = { | |||
| {"test_gridsample_nearest", 2, 1}, | |||
| {"test_gridsample_reflection_padding", 2, 1}, | |||
| {"test_gridsample_zeros_padding", 2, 1}, | |||
| {"test_group_normalization_epsilon", 3, 1}, | |||
| {"test_group_normalization_example", 3, 1}, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jimmylaw21 Friendly reminder. |
dkurt
approved these changes
Jan 12, 2024
|
@jimmylaw21 Thanks a lot for the contribution! Feel free to create a new PR for CANN support too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
dnn onnx: add group norm layer
Todo:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.