Merge pull request #20151 from smirnov-alexey:as/extend_media_frame

smirnov-alexey · web-flow · commit d9ed9a9a83ef · 2021-06-08T11:58:51.000+03:00
G-API: Extend MediaFrame to be able to extract additional info besides access

* Extend MediaFrame to be able to extract additional info besides access

* Add default implementation for blobParams()

* Add comment on the default blobParams()
diff --git a/modules/gapi/include/opencv2/gapi/media.hpp b/modules/gapi/include/opencv2/gapi/media.hpp
@@ -13,6 +13,7 @@
 #include <utility>    // forward<>()
 
 #include <opencv2/gapi/gframe.hpp>
+#include <opencv2/gapi/util/any.hpp>
 
 namespace cv {
 
@@ -30,6 +31,10 @@ class GAPI_EXPORTS MediaFrame {
     View access(Access) const;
     cv::GFrameDesc desc() const;
 
+    // FIXME: design a better solution
+    // Should be used only if the actual adapter provides implementation
+    cv::util::any blobParams() const;
+
     // Cast underlying MediaFrame adapter to the particular adapter type,
     // return nullptr if underlying type is different
     template<typename T> T* get() const
@@ -78,6 +83,9 @@ class GAPI_EXPORTS MediaFrame::IAdapter {
     virtual ~IAdapter() = 0;
     virtual cv::GFrameDesc meta() const = 0;
     virtual MediaFrame::View access(MediaFrame::Access) = 0;
+    // FIXME: design a better solution
+    // The default implementation does nothing
+    virtual cv::util::any blobParams() const;
 };
 
 } //namespace cv
diff --git a/modules/gapi/src/api/media.cpp b/modules/gapi/src/api/media.cpp
@@ -26,6 +26,11 @@ cv::MediaFrame::View cv::MediaFrame::access(Access code) const {
     return m->adapter->access(code);
 }
 
+cv::util::any cv::MediaFrame::blobParams() const
+{
+    return m->adapter->blobParams();
+}
+
 cv::MediaFrame::IAdapter* cv::MediaFrame::getAdapter() const {
     return m->adapter.get();
 }
@@ -42,5 +47,11 @@ cv::MediaFrame::View::~View() {
     }
 }
 
+cv::util::any cv::MediaFrame::IAdapter::blobParams() const
+{
+    // Does nothing by default
+    return {};
+}
+
 cv::MediaFrame::IAdapter::~IAdapter() {
 }
diff --git a/modules/gapi/test/gapi_frame_tests.cpp b/modules/gapi/test/gapi_frame_tests.cpp
@@ -174,4 +174,11 @@ TEST(MediaFrame, Callback) {
     EXPECT_EQ(3, counter);
 }
 
+TEST(MediaFrame, blobParams) {
+    cv::Mat bgr = cv::Mat::eye(240, 320, CV_8UC3);
+    cv::MediaFrame frame = cv::MediaFrame::Create<TestMediaBGR>(bgr);
+
+    EXPECT_NO_THROW(frame.blobParams());
+}
+
 } // namespace opencv_test
diff --git a/modules/gapi/test/infer/gapi_infer_ie_test.cpp b/modules/gapi/test/infer/gapi_infer_ie_test.cpp
@@ -56,6 +56,15 @@ class TestMediaBGR final: public cv::MediaFrame::IAdapter {
         cv::MediaFrame::View::Strides ss = { m_mat.step, 0u, 0u, 0u };
         return cv::MediaFrame::View(std::move(pp), std::move(ss), Cb{m_cb});
     }
+    cv::util::any blobParams() const override {
+        return std::make_pair<InferenceEngine::TensorDesc,
+                              InferenceEngine::ParamMap>({IE::Precision::U8,
+                                                          {1, 3, 300, 300},
+                                                          IE::Layout::NCHW},
+                                                         {{"HELLO", 42},
+                                                          {"COLOR_FORMAT",
+                                                           InferenceEngine::ColorFormat::NV12}});
+    }
 };
 
 class TestMediaNV12 final: public cv::MediaFrame::IAdapter {
@@ -2028,6 +2037,21 @@ TEST_F(ROIList, CallInferMultipleTimes)
     validate();
 }
 
+TEST(IEFrameAdapter, blobParams)
+{
+    cv::Mat bgr = cv::Mat::eye(240, 320, CV_8UC3);
+    cv::MediaFrame frame = cv::MediaFrame::Create<TestMediaBGR>(bgr);
+
+    auto expected = std::make_pair(IE::TensorDesc{IE::Precision::U8, {1, 3, 300, 300},
+                                                  IE::Layout::NCHW},
+                                   IE::ParamMap{{"HELLO", 42}, {"COLOR_FORMAT",
+                                                                IE::ColorFormat::NV12}});
+
+    auto actual = cv::util::any_cast<decltype(expected)>(frame.blobParams());
+
+    EXPECT_EQ(expected, actual);
+}
+
 } // namespace opencv_test
 
 #endif //  HAVE_INF_ENGINE

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,11 @@ cv::MediaFrame::View cv::MediaFrame::access(Access code) const {`
`26`	`26`	`return m->adapter->access(code);`
`27`	`27`	`}`
`28`	`28`
	`29`	`+cv::util::any cv::MediaFrame::blobParams() const`
	`30`	`+{`
	`31`	`+ return m->adapter->blobParams();`
	`32`	`+}`
	`33`	`+`
`29`	`34`	`cv::MediaFrame::IAdapter* cv::MediaFrame::getAdapter() const {`
`30`	`35`	`return m->adapter.get();`
`31`	`36`	`}`
`@@ -42,5 +47,11 @@ cv::MediaFrame::View::~View() {`
`42`	`47`	`}`
`43`	`48`	`}`
`44`	`49`
	`50`	`+cv::util::any cv::MediaFrame::IAdapter::blobParams() const`
	`51`	`+{`
	`52`	`+ // Does nothing by default`
	`53`	`+ return {};`
	`54`	`+}`
	`55`	`+`
`45`	`56`	`cv::MediaFrame::IAdapter::~IAdapter() {`
`46`	`57`	`}`