CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 06:09:01 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/opencv/opencv.git
etag: W/"bf4ab30032650669ff9eeb690c0d6cca"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=C4v0ymRVd2tEfr1BzSIos6z3cFn3nxqVdn8gIhufyFNdI9c97%2BNLopM8v5z3LM8sLin2uGvPsLK20ZLjNv5JkBENDQJV8240QAuGKyJO%2BY3RHjOsbA6pVcgHaBYtgkc1w%2F75iag6uMZ4y%2F%2F%2B8qXECtGBfWSVR5%2BwLoSN2ZHxU%2BApmtBzzNio%2BlQ0DQOUQkR1sO%2BtkIhf7F08yNl7JWICdnjc3B0GdPEQKA3GEA809c1qguVuMxrduwsWfdzB7%2BR4IsHhwtjxs6P7tZwDy6cuJg%3D%3D--mQmQgugQj%2B7Momgs--Gbn1ku1bjQnSQ3spUyuelA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1298451537.1753250940; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 06:09:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 06:09:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AF16:261FF2:4C04C4:633B2D:68807C7C
Merge pull request #23843 from TolyaTalamanov:at/fix-missing-opaque-k… · opencv/opencv@6084851 · GitHub
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/gkernel.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/infer.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/streaming/desync.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/streaming/meta.hpp
Copy file name to clipboardExpand all lines: modules/gapi/misc/python/python_bridge.hpp
Copy file name to clipboardExpand all lines: modules/gapi/misc/python/test/test_gapi_sample_pipelines.py
Copy file name to clipboardExpand all lines: modules/gapi/src/backends/ov/govbackend.cpp
Copy file name to clipboardExpand all lines: modules/gapi/src/compiler/gmodelbuilder.cpp
Copy file name to clipboardExpand all lines: modules/gapi/test/internal/gapi_int_gmodel_builder_test.cpp
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Commit 6084851
authored
Merge pull request #23843 from TolyaTalamanov:at/fix-missing-opaque-kind-for-kernel
G-API: Fix incorrect OpaqueKind for Kernel outputs #23843
### Pull Request Readiness Checklist
#### Overview
The PR is going to fix several problems:
1. Major: `GKernel` doesn't hold `kind` for its outputs. Since `GModelBuilder` traverse graph from outputs to inputs once it reaches any output of the operation it will use its `kind` to create `Data` meta for all operation outputs. Since it essential for `python` to know `GTypeInfo` (which is `shape` and `kind`) it will be confused.
Consider this operation:
```
@cv.gapi.op('custom.square_mean', in_types=[cv.GArray.Int], out_types=[cv.GOpaque.Float, cv.GArray.Int])
class GSquareMean:
@staticmethod
def outMeta(desc):
return cv.empty_gopaque_desc(), cv.empty_array_desc()
```
Even though `GOpaque` is `Float`, corresponding metadata might have `Int` kind because it might be taken from `cv.GArray.Int`
so it will be a problem if one of the outputs of these operation is graph output because python will cast it to the wrong type based on `Data` meta.
2. Minor: Some of the OpenVINO `IR`'s doesn't any layout information for input. It's usually true only for `IRv10` but since `OpenVINO 2.0` need this information to correctly configure resize we need to put default layout if there no such assigned in `ov::Model`.
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake1 parent 61d48dd commit 6084851Copy full SHA for 6084851
File tree
Expand file treeCollapse file tree
9 files changed
+95
-23
lines changedFilter options
- modules/gapi
- include/opencv2/gapi
- streaming
- misc/python
- test
- src
- backends/ov
- compiler
- test/internal
Expand file treeCollapse file tree
9 files changed
+95
-23
lines changedmodules/gapi/include/opencv2/gapi/gkernel.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/gkernel.hpp+5-2Lines changed: 5 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
51 | 51 |
| |
52 | 52 |
| |
53 | 53 |
| |
| 54 | + | |
54 | 55 |
| |
55 | 56 |
| |
56 | 57 |
| |
| |||
227 | 228 |
| |
228 | 229 |
| |
229 | 230 |
| |
230 |
| - | |
| 231 | + | |
| 232 | + | |
231 | 233 |
| |
232 | 234 |
| |
233 | 235 |
| |
| |||
251 | 253 |
| |
252 | 254 |
| |
253 | 255 |
| |
254 |
| - | |
| 256 | + | |
| 257 | + | |
255 | 258 |
| |
256 | 259 |
| |
257 | 260 |
| |
|
modules/gapi/include/opencv2/gapi/infer.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/infer.hpp+3Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
101 | 101 |
| |
102 | 102 |
| |
103 | 103 |
| |
| 104 | + | |
104 | 105 |
| |
105 | 106 |
| |
| 107 | + | |
106 | 108 |
| |
107 | 109 |
| |
108 | 110 |
| |
| |||
175 | 177 |
| |
176 | 178 |
| |
177 | 179 |
| |
| 180 | + | |
178 | 181 |
| |
179 | 182 |
| |
180 | 183 |
| |
|
modules/gapi/include/opencv2/gapi/streaming/desync.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/streaming/desync.hpp+1Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
46 | 46 |
| |
47 | 47 |
| |
48 | 48 |
| |
| 49 | + | |
49 | 50 |
| |
50 | 51 |
| |
51 | 52 |
| |
|
modules/gapi/include/opencv2/gapi/streaming/meta.hpp
Copy file name to clipboardExpand all lines: modules/gapi/include/opencv2/gapi/streaming/meta.hpp+1Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
50 | 50 |
| |
51 | 51 |
| |
52 | 52 |
| |
| 53 | + | |
53 | 54 |
| |
54 | 55 |
| |
55 | 56 |
| |
|
modules/gapi/misc/python/python_bridge.hpp
Copy file name to clipboardExpand all lines: modules/gapi/misc/python/python_bridge.hpp+18-9Lines changed: 18 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
267 | 267 |
| |
268 | 268 |
| |
269 | 269 |
| |
270 |
| - | |
| 270 | + | |
271 | 271 |
| |
272 | 272 |
| |
273 | 273 |
| |
274 | 274 |
| |
275 | 275 |
| |
276 | 276 |
| |
| 277 | + | |
277 | 278 |
| |
278 | 279 |
| |
279 | 280 |
| |
| |||
282 | 283 |
| |
283 | 284 |
| |
284 | 285 |
| |
| 286 | + | |
285 | 287 |
| |
286 | 288 |
| |
287 | 289 |
| |
| |||
290 | 292 |
| |
291 | 293 |
| |
292 | 294 |
| |
293 |
| - | |
294 |
| - | |
295 |
| - | |
296 |
| - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
297 | 303 |
| |
298 | 304 |
| |
299 | 305 |
| |
| |||
302 | 308 |
| |
303 | 309 |
| |
304 | 310 |
| |
305 |
| - | |
306 |
| - | |
307 |
| - | |
308 |
| - | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
309 | 318 |
| |
310 | 319 |
| |
311 | 320 |
| |
|
modules/gapi/misc/python/test/test_gapi_sample_pipelines.py
Copy file name to clipboardExpand all lines: modules/gapi/misc/python/test/test_gapi_sample_pipelines.py+41Lines changed: 41 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
207 | 207 |
| |
208 | 208 |
| |
209 | 209 |
| |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
210 | 240 |
| |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
211 | 252 |
| |
212 | 253 |
| |
213 | 254 |
| |
|
modules/gapi/src/backends/ov/govbackend.cpp
Copy file name to clipboardExpand all lines: modules/gapi/src/backends/ov/govbackend.cpp+13-1Lines changed: 13 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
738 | 738 |
| |
739 | 739 |
| |
740 | 740 |
| |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
741 | 750 |
| |
742 | 751 |
| |
743 | 752 |
| |
| |||
765 | 774 |
| |
766 | 775 |
| |
767 | 776 |
| |
| 777 | + | |
768 | 778 |
| |
769 | 779 |
| |
770 | 780 |
| |
| |||
810 | 820 |
| |
811 | 821 |
| |
812 | 822 |
| |
813 |
| - | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
814 | 826 |
| |
815 | 827 |
| |
816 | 828 |
| |
|
modules/gapi/src/compiler/gmodelbuilder.cpp
Copy file name to clipboardExpand all lines: modules/gapi/src/compiler/gmodelbuilder.cpp+9-9Lines changed: 9 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
59 | 59 |
| |
60 | 60 |
| |
61 | 61 |
| |
62 |
| - | |
63 | 62 |
| |
64 | 63 |
| |
65 | 64 |
| |
| |||
135 | 134 |
| |
136 | 135 |
| |
137 | 136 |
| |
138 |
| - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
139 | 140 |
| |
140 |
| - | |
141 |
| - | |
142 |
| - | |
143 |
| - | |
144 |
| - | |
145 |
| - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
146 | 146 |
| |
147 | 147 |
| |
148 | 148 |
| |
149 |
| - | |
| 149 | + | |
150 | 150 |
| |
151 | 151 |
| |
152 | 152 |
| |
|
modules/gapi/test/internal/gapi_int_gmodel_builder_test.cpp
Copy file name to clipboardExpand all lines: modules/gapi/test/internal/gapi_int_gmodel_builder_test.cpp+4-2Lines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
| 33 | + | |
| 34 | + | |
34 | 35 |
| |
35 | 36 |
| |
36 | 37 |
| |
| |||
41 | 42 |
| |
42 | 43 |
| |
43 | 44 |
| |
44 |
| - | |
| 45 | + | |
| 46 | + | |
45 | 47 |
| |
46 | 48 |
| |
47 | 49 |
| |
|
You can’t perform that action at this time.
0 commit comments