Merge pull request #27353 from MRo47:fix/segfault-on-forward#27352

MRo47 · web-flow · commit 374ad414206d · 2025-05-24T10:07:45.000+03:00
Fix #27352: Add checks before getting latest pin in Net::Impl::getLatestLayerPin() #27353 ### Pull Request Readiness Checklist Fixes #27352 See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
diff --git a/modules/dnn/src/net_impl.cpp b/modules/dnn/src/net_impl.cpp
@@ -1027,6 +1027,8 @@ void Net::Impl::forward(OutputArrayOfArrays outputBlobs,
         const std::vector<String>& outBlobNames)
 {
     CV_Assert(!empty());
+    if (outBlobNames.empty())
+        CV_Error(Error::StsBadArg, "in Net::forward(), outBlobNames cannot be empty");
     FPDenormalsIgnoreHintScope fp_denormals_ignore_scope;
 
     std::vector<LayerPin> pins;
@@ -1056,6 +1058,8 @@ void Net::Impl::forward(std::vector<std::vector<Mat>>& outputBlobs,
         const std::vector<String>& outBlobNames)
 {
     CV_Assert(!empty());
+    if (outBlobNames.empty())
+        CV_Error(Error::StsBadArg, "in Net::forward(), outBlobNames cannot be empty");
     FPDenormalsIgnoreHintScope fp_denormals_ignore_scope;
 
     std::vector<LayerPin> pins;
@@ -1316,6 +1320,9 @@ void Net::Impl::updateLayersShapes()
 
 LayerPin Net::Impl::getLatestLayerPin(const std::vector<LayerPin>& pins) const
 {
+    if (pins.empty())
+        CV_Error(Error::StsBadArg,
+                 "Cannot Net::Impl::getLatestLayerPin() from empty vector of pins");
     return *std::max_element(pins.begin(), pins.end());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1027,6 +1027,8 @@ void Net::Impl::forward(OutputArrayOfArrays outputBlobs,`
`1027`	`1027`	`const std::vector<String>& outBlobNames)`
`1028`	`1028`	`{`
`1029`	`1029`	`CV_Assert(!empty());`
	`1030`	`+ if (outBlobNames.empty())`
	`1031`	`+ CV_Error(Error::StsBadArg, "in Net::forward(), outBlobNames cannot be empty");`
`1030`	`1032`	`FPDenormalsIgnoreHintScope fp_denormals_ignore_scope;`
`1031`	`1033`
`1032`	`1034`	`std::vector<LayerPin> pins;`
`@@ -1056,6 +1058,8 @@ void Net::Impl::forward(std::vector<std::vector<Mat>>& outputBlobs,`
`1056`	`1058`	`const std::vector<String>& outBlobNames)`
`1057`	`1059`	`{`
`1058`	`1060`	`CV_Assert(!empty());`
	`1061`	`+ if (outBlobNames.empty())`
	`1062`	`+ CV_Error(Error::StsBadArg, "in Net::forward(), outBlobNames cannot be empty");`
`1059`	`1063`	`FPDenormalsIgnoreHintScope fp_denormals_ignore_scope;`
`1060`	`1064`
`1061`	`1065`	`std::vector<LayerPin> pins;`
`@@ -1316,6 +1320,9 @@ void Net::Impl::updateLayersShapes()`
`1316`	`1320`
`1317`	`1321`	`LayerPin Net::Impl::getLatestLayerPin(const std::vector<LayerPin>& pins) const`
`1318`	`1322`	`{`
	`1323`	`+ if (pins.empty())`
	`1324`	`+ CV_Error(Error::StsBadArg,`
	`1325`	`+ "Cannot Net::Impl::getLatestLayerPin() from empty vector of pins");`
`1319`	`1326`	`return *std::max_element(pins.begin(), pins.end());`
`1320`	`1327`	`}`
`1321`	`1328`