You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.3 introduced Prism parser, and it is also released as a gem.
The latest version of Prism includes Prism::Tarnslaion::Parser, a wrapper class to make Prism compatible with parser gem (whitequark/parser).
This PR tries to replace the current parser (Parser::Ruby32) with Prism::Tranlation::Parser.
Since this is just an experiment, the default parser remains to be that of parser gem. Instead I added --prism CLI option to switch the parser.
There's a small issue for opalopal as of now which regards loading of WASM modules - they can be only loaded async (at least in Chromium). I have a plan to support such workflow, but it will take some time.
Other than that, before we flip the default, we will also have to check regressions in source maps.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 introduced Prism parser, and it is also released as a gem.
The latest version of Prism includes
Prism::Tarnslaion::Parser
, a wrapper class to make Prism compatible with parser gem (whitequark/parser
).This PR tries to replace the current parser (
Parser::Ruby32
) withPrism::Tranlation::Parser
.Since this is just an experiment, the default parser remains to be that of parser gem. Instead I added
--prism
CLI option to switch the parser.Here are some advantages with Prism:
Todo:
cc: @kddnewton