fix(enum): strip quotes from enum values (#781)

mnahkies · web-flow · commit b92e71ff6e7a · 2020-06-14T12:40:41.000-07:00
diff --git a/lib/endpoint/tags/table.js b/lib/endpoint/tags/table.js
@@ -163,7 +163,7 @@ function rowToParameter(i, el) {
           .pop()
           .match(/`([^`]+)`/g);
 
-        enumValues = _.uniq((results || []).map((s) => s.replace(/`/g, "")));
+        enumValues = _.uniq((results || []).map((s) => s.replace(/[`"]/g, "")));
       }
 
       // Sometimes enum values contain placeholders in which case we turn it into a
diff --git a/openapi/api.github.com/operations/repos/update-information-about-pages-site.json b/openapi/api.github.com/operations/repos/update-information-about-pages-site.json
@@ -65,7 +65,7 @@
             "source": {
               "type": "string",
               "description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
-              "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]
+              "enum": ["gh-pages", "master", "master /docs"]
             }
           }
         },
diff --git a/openapi/ghe-2.18/operations/repos/update-information-about-pages-site.json b/openapi/ghe-2.18/operations/repos/update-information-about-pages-site.json
@@ -67,7 +67,7 @@
             "source": {
               "type": "string",
               "description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
-              "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]
+              "enum": ["gh-pages", "master", "master /docs"]
             }
           }
         },
diff --git a/openapi/ghe-2.19/operations/repos/update-information-about-pages-site.json b/openapi/ghe-2.19/operations/repos/update-information-about-pages-site.json
@@ -61,7 +61,7 @@
             "source": {
               "type": "string",
               "description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
-              "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]
+              "enum": ["gh-pages", "master", "master /docs"]
             }
           }
         },
diff --git a/openapi/ghe-2.20/operations/repos/update-information-about-pages-site.json b/openapi/ghe-2.20/operations/repos/update-information-about-pages-site.json
@@ -61,7 +61,7 @@
             "source": {
               "type": "string",
               "description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
-              "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]
+              "enum": ["gh-pages", "master", "master /docs"]
             }
           }
         },
diff --git a/openapi/ghe-2.21/operations/repos/update-information-about-pages-site.json b/openapi/ghe-2.21/operations/repos/update-information-about-pages-site.json
@@ -61,7 +61,7 @@
             "source": {
               "type": "string",
               "description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
-              "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]
+              "enum": ["gh-pages", "master", "master /docs"]
             }
           }
         },

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ function rowToParameter(i, el) {`
`163`	`163`	`.pop()`
`164`	`164`	.match(/`([^`]+)`/g);
`165`	`165`
`166`		- enumValues = _.uniq((results \|\| []).map((s) => s.replace(/`/g, "")));
	`166`	+ enumValues = _.uniq((results \|\| []).map((s) => s.replace(/[`"]/g, "")));
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`// Sometimes enum values contain placeholders in which case we turn it into a`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@`
`65`	`65`	`"source": {`
`66`	`66`	`"type": "string",`
`67`	`67`	"description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
`68`		`- "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]`
	`68`	`+ "enum": ["gh-pages", "master", "master /docs"]`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`	`},`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@`
`67`	`67`	`"source": {`
`68`	`68`	`"type": "string",`
`69`	`69`	"description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
`70`		`- "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]`
	`70`	`+ "enum": ["gh-pages", "master", "master /docs"]`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`	`},`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@`
`61`	`61`	`"source": {`
`62`	`62`	`"type": "string",`
`63`	`63`	"description": "Update the source for the repository. Must include the branch name, and may optionally specify the subdirectory `/docs`. Possible values are `\"gh-pages\"`, `\"master\"`, and `\"master /docs\"`.",
`64`		`- "enum": ["\"gh-pages\"", "\"master\"", "\"master /docs\""]`
	`64`	`+ "enum": ["gh-pages", "master", "master /docs"]`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`	`},`