fix: add missing deprecations for repos/list-commit-comments, which was renamed to repos/list-commit-comments-for-repo (#771)

gr2m · web-flow · commit 5cc663863c48 · 2020-06-07T10:42:39.000-07:00
diff --git a/lib/endpoint/overrides/deprecations.js b/lib/endpoint/overrides/deprecations.js
@@ -2773,6 +2773,14 @@ function deprecations({ routes, gheVersion }) {
     "users/list-public-emails-for-authenticated-user"
   );
 
+  addOperationIdRename(
+    routes,
+    "GET /repos/{owner}/{repo}/comments",
+    "2020-06-04",
+    "repos/list-commit-comments",
+    "repos/list-commit-comments-for-repo"
+  );
+
   addOperationIdRename(
     routes,
     "GET /projects/{project_id}/collaborators/{username}/permission",
diff --git a/openapi/api.github.com/operations/repos/list-commit-comments-for-repo.json b/openapi/api.github.com/operations/repos/list-commit-comments-for-repo.json
@@ -160,5 +160,13 @@
       }
     ]
   },
-  "x-changes": []
+  "x-changes": [
+    {
+      "type": "operation",
+      "date": "2020-06-04",
+      "note": "\"repos/list-commit-comments\" operation ID is now \"repos/list-commit-comments-for-repo\"",
+      "before": { "operationId": "repos/list-commit-comments" },
+      "after": { "operationId": "repos/list-commit-comments-for-repo" }
+    }
+  ]
 }
diff --git a/openapi/ghe-2.18/operations/repos/list-commit-comments-for-repo.json b/openapi/ghe-2.18/operations/repos/list-commit-comments-for-repo.json
@@ -154,5 +154,13 @@
     "githubCloudOnly": false,
     "previews": []
   },
-  "x-changes": []
+  "x-changes": [
+    {
+      "type": "operation",
+      "date": "2020-06-04",
+      "note": "\"repos/list-commit-comments\" operation ID is now \"repos/list-commit-comments-for-repo\"",
+      "before": { "operationId": "repos/list-commit-comments" },
+      "after": { "operationId": "repos/list-commit-comments-for-repo" }
+    }
+  ]
 }
diff --git a/openapi/ghe-2.19/operations/repos/list-commit-comments-for-repo.json b/openapi/ghe-2.19/operations/repos/list-commit-comments-for-repo.json
@@ -154,5 +154,13 @@
     "githubCloudOnly": false,
     "previews": []
   },
-  "x-changes": []
+  "x-changes": [
+    {
+      "type": "operation",
+      "date": "2020-06-04",
+      "note": "\"repos/list-commit-comments\" operation ID is now \"repos/list-commit-comments-for-repo\"",
+      "before": { "operationId": "repos/list-commit-comments" },
+      "after": { "operationId": "repos/list-commit-comments-for-repo" }
+    }
+  ]
 }
diff --git a/openapi/ghe-2.20/operations/repos/list-commit-comments-for-repo.json b/openapi/ghe-2.20/operations/repos/list-commit-comments-for-repo.json
@@ -154,5 +154,13 @@
     "githubCloudOnly": false,
     "previews": []
   },
-  "x-changes": []
+  "x-changes": [
+    {
+      "type": "operation",
+      "date": "2020-06-04",
+      "note": "\"repos/list-commit-comments\" operation ID is now \"repos/list-commit-comments-for-repo\"",
+      "before": { "operationId": "repos/list-commit-comments" },
+      "after": { "operationId": "repos/list-commit-comments-for-repo" }
+    }
+  ]
 }

Original file line number	Diff line number	Diff line change
`@@ -160,5 +160,13 @@`
`160`	`160`	`}`
`161`	`161`	`]`
`162`	`162`	`},`
`163`		`- "x-changes": []`
	`163`	`+ "x-changes": [`
	`164`	`+ {`
	`165`	`+ "type": "operation",`
	`166`	`+ "date": "2020-06-04",`
	`167`	`+ "note": "\"repos/list-commit-comments\" operation ID is now \"repos/list-commit-comments-for-repo\"",`
	`168`	`+ "before": { "operationId": "repos/list-commit-comments" },`
	`169`	`+ "after": { "operationId": "repos/list-commit-comments-for-repo" }`
	`170`	`+ }`
	`171`	`+ ]`
`164`	`172`	`}`