| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 01:46:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=525.526293,conversation_content-fragment;desc="conversation_content fragment";dur=1592.640403,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=402.987099,nginx;desc="NGINX";dur=0.607167,glb;desc="GLB";dur=138.771138
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BsG7pSh5g%2BbabV%2FtUx9yGb4WBCjlxAhEjWYb0PJGHAOQrvNfARGBc%2BOVqzjvba242xPKi1Zcw118mrk%2F9heXJxb1p1U0JzCCDhTkBdgg5L096wanBpzZZwzi1LeBR4fZbskDFTIdvZePZImEg3mvc%2BFz3B%2B9tFKg9ImsZT9LuQBj7M8kmg9WOZeN39TVyfcP17OYOrTz5GEsEXVDPxASfgn0w0ZHV1Wwkasl05SMPSvDF9qeMbRC6xI403VTkV9FA0NSbINI16Uw9B3Ggom5RQ%3D%3D--CrzDGulBOIXmCFBy--G63st75QmI9nBC2GZ%2FkOlg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.565163881.1760147179; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 01:46:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 01:46:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DC88:19F5EE:1E4A9F:2C87B0:68E9B6EB
path,win: fix bug in resolve and normalize by huseyinacacak-janea · Pull Request #55623 · nodejs/node · GitHub
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
path
Issues and PRs related to the path subsystem.
labels
Oct 31, 2024
StefanStojanovic
added
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 1, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 1, 2024
aduh95
added
baking-for-lts
PRs that need to wait before landing in a LTS release.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
needs-citgm
PRs that need a CITGM CI run.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 4, 2024
aduh95
added
request-ci
Add this label to start a Jenkins CI on a PR.
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 5, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 5, 2024
Flarna
added
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
labels
Nov 29, 2024
Flarna
removed
dont-land-on-v18.x
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
labels
Dec 23, 2024
aduh95
removed
the
baking-for-lts
PRs that need to wait before landing in a LTS release.
label
Jan 7, 2025
aduh95
added
the
backport-requested-v22.x
PRs awaiting manual backport to the v22.x-staging branch.
label
Feb 4, 2025
RafaelGSS
added
backport-open-v22.x
Indicate that the PR has an open backport
and removed
backport-requested-v22.x
PRs awaiting manual backport to the v22.x-staging branch.
labels
Sep 9, 2025
richardlau
added
backported-to-v22.x
PRs backported to the v22.x-staging branch.
and removed
backport-open-v22.x
Indicate that the PR has an open backport
labels
Sep 17, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
path,win: fix bug in resolve and normalize #55623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
JaneaSystems:huseyin-12648-physical-drive-broken
Nov 5, 2024
Merged
path,win: fix bug in resolve and normalize #55623
nodejs-github-bot
merged 1 commit into
nodejs:main
from
JaneaSystems:huseyin-12648-physical-drive-broken
Nov 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
avivkeller
reviewed
Oct 31, 2024
| assert.strictEqual(path.win32.toNamespacedPath('//foo//bar'), | ||
| '\\\\?\\UNC\\foo\\bar\\'); | ||
| assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo\\'); | ||
| assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is stripping the / okay? We wouldn't want to repeat that happened with npm 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be OK since this PR doesn't change anything other than this particular path format. But yes, it would be useful to see the citgm test results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a CITGM would be nice. I've applied the labels. If possible, could you also run npm's test suite? The CITGM doesn't cover all of it, and IMO we should be extra cautious JIC.
Although, it seems like it should be fine. Just want to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the test in the npm repo locally and didn't encounter any problems.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55623 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 654 654
Lines 187698 187729 +31
Branches 36126 36135 +9
=======================================
+ Hits 165986 166024 +38
Misses 14953 14953
+ Partials 6759 6752 -7
🚀 New features to boost your workflow:
|
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
|
CITGM ( SUCCESS: No new failures in 3501 compared to 3499 🎉 |
aduh95
approved these changes
Nov 4, 2024
aduh95
added
baking-for-lts
BridgeAR
approved these changes
Nov 4, 2024
lpinca
approved these changes
Nov 5, 2024
aduh95
added
request-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7f68e54 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Fixes: nodejs#54025 PR-URL: nodejs#55623 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Flarna
added
dont-land-on-v20.x
This was referenced Nov 30, 2024
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
ruyadorno
pushed a commit
that referenced
this pull request
Dec 20, 2024
Flarna
removed
dont-land-on-v18.x
dont-land-on-v20.x
ruyadorno
pushed a commit
that referenced
this pull request
Jan 5, 2025
aduh95
removed
the
baking-for-lts
|
I had to drop it from 22.14.0 proposal as the following test was failing:
|
aduh95
added
the
backport-requested-v22.x
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Sep 9, 2025
Fixes: nodejs#54025 PR-URL: nodejs#55623 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
added
backport-open-v22.x
richardlau
added
backported-to-v22.x
2 tasks
otaviojacobi
added a commit
to balena-io/balena-cli
that referenced
this pull request
Oct 8, 2025
This fixes local flash (and all other flashes) on windows machines after a bugfix in a issue coming from nodejs See: nodejs/node#55623 See: #2959 Change-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v22.x
PRs backported to the v22.x-staging branch.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
path
Issues and PRs related to the path subsystem.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR fixes resolving device paths like
\\.\PHYSICALDRIVE.The
resolveandnormalizefunctions were adding a trailing backslash, considering that this device path was a UNC path. However, device paths are different than UNC paths.In addition to fixing this issue, the previous attempt also fixed other inconsistencies. So, this PR only fixes the issue itself.
Previous PR: #54224
Fixes: #54025