test_runner: fix isSkipped check in junit

mete0rfish · web-flow · commit f7a2ba7e8378 · 2025-08-13T08:50:42.000Z
The `isSkipped` function in the JUnit reporter was incorrectly checking for `node?.attrs.failures` instead of `node?.attrs.skipped`. PR-URL: #59414 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
diff --git a/lib/internal/test_runner/reporter/junit.js b/lib/internal/test_runner/reporter/junit.js
@@ -58,7 +58,7 @@ function isFailure(node) {
 }
 
 function isSkipped(node) {
-  return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) || node?.attrs?.failures;
+  return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) || node?.attrs?.skipped;
 }
 
 module.exports = async function* junitReporter(source) {
diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js
@@ -191,4 +191,17 @@ describe('node:test reporters', { concurrency: true }, () => {
     assert.match(fileConent, /ℹ skipped 0/);
     assert.match(fileConent, /ℹ todo 0/);
   });
+
+  it('should correctly report pass/fail for junit reporter using reporters.js', async () => {
+    const file = tmpdir.resolve(`${tmpFiles++}.xml`);
+    const child = spawnSync(process.execPath,
+                            ['--test', '--test-reporter', 'junit', '--test-reporter-destination', file, testFile]);
+    assert.strictEqual(child.stderr.toString(), '');
+    assert.strictEqual(child.stdout.toString(), '');
+    const fileContents = fs.readFileSync(file, 'utf8');
+    assert.match(fileContents, /<testsuite .*name="nested".*tests="2".*failures="1".*skipped="0".*>/);
+    assert.match(fileContents, /<testcase .*name="failing".*>\s*<failure .*type="testCodeFailure".*message="error".*>/);
+    assert.match(fileContents, /<testcase .*name="ok".*classname="test".*\/>/);
+    assert.match(fileContents, /<testcase .*name="top level".*classname="test".*\/>/);
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ function isFailure(node) {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`function isSkipped(node) {`
`61`		`- return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) \|\| node?.attrs?.failures;`
	`61`	`+ return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) \|\| node?.attrs?.skipped;`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`module.exports = async function* junitReporter(source) {`