lib: refactor execution.js

marco-ippolito · aduh95 · commit c2baae84ce62 · 2025-01-02T15:28:50.000+01:00
PR-URL: #56358 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me>
diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -84,38 +84,19 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) {
       evalModuleEntryPoint(body, print);
   }
 
-  const runScript = () => {
-    // Create wrapper for cache entry
-    const script = `
-      globalThis.module = module;
-      globalThis.exports = exports;
-      globalThis.__dirname = __dirname;
-      globalThis.require = require;
-      return (main) => main();
-    `;
-    globalThis.__filename = name;
-    RegExpPrototypeExec(/^/, ''); // Necessary to reset RegExp statics before user code runs.
-    const result = module._compile(script, `${name}-wrapper`)(() => {
-      const compiledScript = compileScript(name, body, baseUrl);
-      return runScriptInThisContext(compiledScript, true, !!breakFirstLine);
-    });
-    if (print) {
-      const { log } = require('internal/console/global');
-
-      process.on('exit', () => {
-        log(result);
-      });
-    }
-
-    if (origModule !== undefined)
-      globalThis.module = origModule;
-  };
+  const evalFunction = () => runScriptInContext(name,
+                                                body,
+                                                breakFirstLine,
+                                                print,
+                                                module,
+                                                baseUrl,
+                                                undefined,
+                                                origModule);
 
   if (shouldLoadESM) {
-    require('internal/modules/run_main').runEntryPointWithESMLoader(runScript);
-    return;
+    return require('internal/modules/run_main').runEntryPointWithESMLoader(evalFunction);
   }
-  runScript();
+  evalFunction();
 }
 
 const exceptionHandlerState = {
@@ -301,19 +282,19 @@ function evalTypeScript(name, source, breakFirstLine, print, shouldLoadESM = fal
     }
   }
 
+  const evalFunction = () => runScriptInContext(name,
+                                                sourceToRun,
+                                                breakFirstLine,
+                                                print,
+                                                module,
+                                                baseUrl,
+                                                compiledScript,
+                                                origModule);
+
   if (shouldLoadESM) {
-    return require('internal/modules/run_main').runEntryPointWithESMLoader(
-      () => runScriptInContext(name,
-                               sourceToRun,
-                               breakFirstLine,
-                               print,
-                               module,
-                               baseUrl,
-                               compiledScript,
-                               origModule));
+    return require('internal/modules/run_main').runEntryPointWithESMLoader(evalFunction);
   }
-
-  runScriptInContext(name, sourceToRun, breakFirstLine, print, module, baseUrl, compiledScript, origModule);
+  evalFunction();
 }
 
 /**
@@ -476,7 +457,7 @@ function runScriptInContext(name, body, breakFirstLine, print, module, baseUrl,
   const result = module._compile(script, `${name}-wrapper`)(() => {
     // If the script was already compiled, use it.
     return runScriptInThisContext(
-      compiledScript,
+      compiledScript ?? compileScript(name, body, baseUrl),
       true, !!breakFirstLine);
   });
   if (print) {
