lib: add typescript support to STDIN eval

marco-ippolito · aduh95 · commit c1023284c3aa · 2025-01-02T15:28:50.000+01:00
PR-URL: #56359 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
diff --git a/doc/api/typescript.md b/doc/api/typescript.md
@@ -156,10 +156,10 @@ import { fn, FnParams } from './fn.ts';
 
 ### Non-file forms of input
 
-Type stripping can be enabled for `--eval`. The module system
+Type stripping can be enabled for `--eval` and STDIN. The module system
 will be determined by `--input-type`, as it is for JavaScript.
 
-TypeScript syntax is unsupported in the REPL, STDIN input, `--print`, `--check`, and
+TypeScript syntax is unsupported in the REPL, `--check`, and
 `inspect`.
 
 ### Source maps
diff --git a/lib/internal/main/eval_stdin.js b/lib/internal/main/eval_stdin.js
@@ -11,6 +11,9 @@ const { getOptionValue } = require('internal/options');
 
 const {
   evalModuleEntryPoint,
+  evalTypeScript,
+  parseAndEvalCommonjsTypeScript,
+  parseAndEvalModuleTypeScript,
   evalScript,
   readStdin,
 } = require('internal/process/execution');
@@ -25,13 +28,30 @@ readStdin((code) => {
 
   const print = getOptionValue('--print');
   const shouldLoadESM = getOptionValue('--import').length > 0;
-  if (getOptionValue('--input-type') === 'module') {
+  const inputType = getOptionValue('--input-type');
+  const tsEnabled = getOptionValue('--experimental-strip-types');
+  if (inputType === 'module') {
     evalModuleEntryPoint(code, print);
+  } else if (inputType === 'module-typescript' && tsEnabled) {
+    parseAndEvalModuleTypeScript(code, print);
   } else {
-    evalScript('[stdin]',
-               code,
-               getOptionValue('--inspect-brk'),
-               print,
-               shouldLoadESM);
+
+    let evalFunction;
+    if (inputType === 'commonjs') {
+      evalFunction = evalScript;
+    } else if (inputType === 'commonjs-typescript' && tsEnabled) {
+      evalFunction = parseAndEvalCommonjsTypeScript;
+    } else if (tsEnabled) {
+      evalFunction = evalTypeScript;
+    } else {
+      // Default to commonjs.
+      evalFunction = evalScript;
+    }
+
+    evalFunction('[stdin]',
+                 code,
+                 getOptionValue('--inspect-brk'),
+                 print,
+                 shouldLoadESM);
   }
 });
diff --git a/test/fixtures/eval/stdin_messages.snapshot b/test/fixtures/eval/stdin_messages.snapshot
@@ -2,10 +2,17 @@
 [stdin]:1
 with(this){__filename}
 ^^^^
+  x The 'with' statement is not supported. All symbols in a 'with' block will have type 'any'.
+   ,----
+ 1 | with(this){__filename}
+   : ^^^^
+   `----
 
-SyntaxError: Strict mode code may not include a with statement
 
+Caused by:
+    failed to parse
 
+SyntaxError: Strict mode code may not include a with statement
 
 
 
diff --git a/test/fixtures/eval/stdin_typescript.js b/test/fixtures/eval/stdin_typescript.js
@@ -0,0 +1,38 @@
+'use strict';
+
+require('../../common');
+
+const spawn = require('child_process').spawn;
+
+function run(cmd, strict, cb) {
+    const args = ['--disable-warning=ExperimentalWarning'];
+    if (strict) args.push('--use_strict');
+    args.push('-p');
+    const child = spawn(process.execPath, args);
+    child.stdout.pipe(process.stdout);
+    child.stderr.pipe(process.stdout);
+    child.stdin.end(cmd);
+    child.on('close', cb);
+}
+
+const queue =
+    [
+        'enum Foo{};',
+        'throw new SyntaxError("hello")',
+        'const foo;',
+        'let x: number = 100;x;',
+        'const foo: string = 10;',
+        'function foo(){};foo<Number>(1);',
+        'interface Foo{};const foo;',
+        'function foo(){ await Promise.resolve(1)};',
+    ];
+
+function go() {
+    const c = queue.shift();
+    if (!c) return console.log('done');
+    run(c, false, function () {
+        run(c, true, go);
+    });
+}
+
+go();
diff --git a/test/fixtures/eval/stdin_typescript.snapshot b/test/fixtures/eval/stdin_typescript.snapshot
@@ -0,0 +1,191 @@
+[stdin]:1
+enum Foo{};
+^^^^
+  x TypeScript enum is not supported in strip-only mode
+   ,----
+ 1 | enum Foo{};
+   : ^^^^^^^^^^
+   `----
+
+
+SyntaxError: Unexpected reserved word
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+enum Foo{};
+^^^^
+  x TypeScript enum is not supported in strip-only mode
+   ,----
+ 1 | enum Foo{};
+   : ^^^^^^^^^^
+   `----
+
+
+SyntaxError: Unexpected reserved word
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+throw new SyntaxError("hello")
+^
+
+SyntaxError: hello
+
+
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+throw new SyntaxError("hello")
+^
+
+SyntaxError: hello
+
+
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+const foo;
+      ^^^
+
+SyntaxError: Missing initializer in const declaration
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+const foo;
+      ^^^
+
+SyntaxError: Missing initializer in const declaration
+
+
+
+
+
+
+
+
+
+Node.js *
+100
+100
+undefined
+undefined
+false
+false
+[stdin]:1
+               ;const foo;
+                      ^^^
+
+SyntaxError: Missing initializer in const declaration
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+               ;const foo;
+                      ^^^
+
+SyntaxError: Missing initializer in const declaration
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+function foo(){ await Promise.resolve(1)};
+                ^^^^^
+  x await isn't allowed in non-async function
+   ,----
+ 1 | function foo(){ await Promise.resolve(1)};
+   :                       ^^^^^^^
+   `----
+
+
+Caused by:
+    failed to parse
+
+SyntaxError: await is only valid in async functions and the top level bodies of modules
+
+
+
+
+
+
+
+
+
+Node.js *
+[stdin]:1
+function foo(){ await Promise.resolve(1)};
+                ^^^^^
+  x await isn't allowed in non-async function
+   ,----
+ 1 | function foo(){ await Promise.resolve(1)};
+   :                       ^^^^^^^
+   `----
+
+
+Caused by:
+    failed to parse
+
+SyntaxError: await is only valid in async functions and the top level bodies of modules
+
+
+
+
+
+
+
+
+
+Node.js *
+done
diff --git a/test/parallel/test-node-output-eval.mjs b/test/parallel/test-node-output-eval.mjs
@@ -24,6 +24,7 @@ describe('eval output', { concurrency: true }, () => {
   const tests = [
     { name: 'eval/eval_messages.js' },
     { name: 'eval/stdin_messages.js' },
+    { name: 'eval/stdin_typescript.js' },
   ];
 
   for (const { name } of tests) {
