tools: disable nullability-completeness warnings

targos · richardlau · commit 91fa83fffdba · 2025-09-20T03:32:54.000Z
Seems Clang-specific and doesn't only affect macOS. This is a very noisy warning from abseil-cpp. PR-URL: #59392 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi
@@ -165,6 +165,23 @@
           },
         },
       }],
+      ['clang==1', {
+        'cflags_cc': [
+          '-Wno-nullability-completeness',
+        ],
+        'xcode_settings': {
+          'OTHER_CFLAGS': [
+            '-Wno-nullability-completeness',
+          ],
+        },
+        'msvs_settings': {
+          'VCCLCompilerTool': {
+            'AdditionalOptions': [
+              '-Wno-nullability-completeness',
+            ],
+          },
+        },
+      }],
       ['v8_target_arch=="arm"', {
         'defines': [
           'V8_TARGET_ARCH_ARM',
