esm: sync-ify module translation

joyeecheung · richardlau · commit 8c4dcd5199ba · 2025-09-20T03:33:20.000Z
This completes the TODO to compile WASM synchronously and thus making translation (i.e. compilation + instantiation) synchronous. PR-URL: #59453 Refs: #55782 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
@@ -527,7 +527,7 @@ class ModuleLoader {
    *                        matching translators.
    * @param {ModuleSource} source Source of the module to be translated.
    * @param {boolean} isMain Whether the module to be translated is the entry point.
-   * @returns {ModuleWrap | Promise<ModuleWrap>}
+   * @returns {ModuleWrap}
    */
   #translate(url, format, source, isMain) {
     this.validateLoadResult(url, format);
@@ -537,7 +537,9 @@ class ModuleLoader {
       throw new ERR_UNKNOWN_MODULE_FORMAT(format, url);
     }
 
-    return FunctionPrototypeCall(translator, this, url, source, isMain);
+    const result = FunctionPrototypeCall(translator, this, url, source, isMain);
+    assert(result instanceof ModuleWrap);
+    return result;
   }
 
   /**
diff --git a/lib/internal/modules/esm/translators.js b/lib/internal/modules/esm/translators.js
@@ -432,17 +432,14 @@ translators.set('json', function jsonStrategy(url, source) {
  * >} [[Instance]] slot proxy for WebAssembly Module Record
  */
 const wasmInstances = new SafeWeakMap();
-translators.set('wasm', async function(url, source) {
+translators.set('wasm', function(url, source) {
   assertBufferSource(source, false, 'load');
 
   debug(`Translating WASMModule ${url}`);
 
   let compiled;
   try {
-    // TODO(joyeecheung): implement a translator that just uses
-    // compiled = new WebAssembly.Module(source) to compile it
-    // synchronously.
-    compiled = await WebAssembly.compile(source, {
+    compiled = new WebAssembly.Module(source, {
       builtins: ['js-string'],
     });
   } catch (err) {
