path: refactor path joining logic for clarity and performance

wlgh1553 · richardlau · commit 658c31d60cb6 · 2025-09-20T06:17:29.000Z
PR-URL: #59781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/path.js b/lib/path.js
@@ -24,6 +24,7 @@
 const {
   ArrayPrototypeIncludes,
   ArrayPrototypeJoin,
+  ArrayPrototypePush,
   ArrayPrototypeSlice,
   FunctionPrototypeBind,
   StringPrototypeCharCodeAt,
@@ -521,22 +522,21 @@ const win32 = {
     if (args.length === 0)
       return '.';
 
-    let joined;
-    let firstPart;
+    const path = [];
     for (let i = 0; i < args.length; ++i) {
       const arg = args[i];
       validateString(arg, 'path');
       if (arg.length > 0) {
-        if (joined === undefined)
-          joined = firstPart = arg;
-        else
-          joined += `\\${arg}`;
+        ArrayPrototypePush(path, arg);
       }
     }
 
-    if (joined === undefined)
+    if (path.length === 0)
       return '.';
 
+    const firstPart = path[0];
+    let joined = ArrayPrototypeJoin(path, '\\');
+
     // Make sure that the joined path doesn't start with two slashes, because
     // normalize() will mistake it for a UNC path then.
     //
