build: disable test-asan workflow

targos · targos · commit 3c40868fd37e · 2024-07-28T08:53:25.000+02:00
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/.github/workflows/test-asan.yml b/.github/workflows/test-asan.yml
@@ -38,7 +38,7 @@ permissions:
 
 jobs:
   test-asan:
-    if: github.event.pull_request.draft == false
+    if: false  # Temporarily disabled. References: https://github.com/nodejs/node/pull/52374, https://github.com/nodejs/node/pull/53651#issuecomment-2198510810
     runs-on: ubuntu-20.04
     env:
       CC: sccache clang
