fix(pipe): handle non string input (#893)

Jesse Rolheiser · ocombe · commit 9ff74dc069ba · 2020-02-05T17:26:47.000+01:00
diff --git a/projects/ngx-translate/core/src/lib/translate.pipe.ts b/projects/ngx-translate/core/src/lib/translate.pipe.ts
@@ -37,7 +37,7 @@ export class TranslatePipe implements PipeTransform, OnDestroy {
   }
 
   transform(query: string, ...args: any[]): any {
-    if (!query || query.length === 0) {
+    if (!query || !query.length) {
       return query;
     }
 
diff --git a/projects/ngx-translate/core/tests/translate.pipe.spec.ts b/projects/ngx-translate/core/tests/translate.pipe.spec.ts
@@ -161,6 +161,15 @@ describe('TranslatePipe', () => {
     }).toThrowError(`Wrong parameter in TranslatePipe. Expected a valid Object, received: ${param}`);
   });
 
+  it("should return given falsey or non length query", () => {
+    translate.setTranslation('en', {"TEST": "This is a test"});
+    translate.use('en');
+
+    expect(translatePipe.transform(null)).toBeNull();
+    expect(translatePipe.transform(undefined)).toBeUndefined();
+    expect(translatePipe.transform(1234 as any)).toBe(1234);
+  });
+
   describe('should update translations on lang change', () => {
     it('with fake loader', (done) => {
       translate.setTranslation('en', {"TEST": "This is a test"});

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export class TranslatePipe implements PipeTransform, OnDestroy {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`transform(query: string, ...args: any[]): any {`
`40`		`- if (!query \|\| query.length === 0) {`
	`40`	`+ if (!query \|\| !query.length) {`
`41`	`41`	`return query;`
`42`	`42`	`}`
`43`	`43`