You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: This branch is based off of sourcemap_fix_relpath, otherwise it would not make any sense.
Sourcemaps can now be constructed for nodes built while parsing SASS (engine.rb). A few fixes to the existing code have been made. All SCSS sourcemap tests have received their SASS counterparts.
Well the sourcemap can map all lines/columns from original sources into their destination CSS.
What this enables on the tool side: ctrl-click any property/value/selector and go to the location in the sass/scss where that originates: the expression, mixin, variable where it was birthed or computed. This makes the editing experience of working with sass and tweaking CSS much more enjoyable.
The UI side of the above is ready, and this PR enables the sourcemap that can deliver the mapping from sass to the tool.
Down the line I can imagine editing values on the right styles pane of Chrome DevTools and changing the original scss source.
@ruudk: You did not specify the actual cache location after --cache-location, thus sass thinks that --sourcemap IS your desired --cache-location value.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: This branch is based off of
sourcemap_fix_relpath
, otherwise it would not make any sense.Sourcemaps can now be constructed for nodes built while parsing SASS (
engine.rb
). A few fixes to the existing code have been made. All SCSS sourcemap tests have received their SASS counterparts.