fix(api): delete all autocmds with the same ID

lewis6991 · lewis6991 · commit dc3bbd31a9d6 · 2022-04-01T08:38:58.000+01:00
diff --git a/src/nvim/autocmd.c b/src/nvim/autocmd.c
@@ -2353,17 +2353,20 @@ int autocmd_delete_event(int group, event_T event, char_u *pat)
 bool autocmd_delete_id(int64_t id)
 {
   assert(id > 0);
+  bool success = false;
+
+  // Note that since multiple AutoCmd objects can have the same ID, we need to do a full scan.
   FOR_ALL_AUEVENTS(event) {
     FOR_ALL_AUPATS_IN_EVENT(event, ap) {
       for (AutoCmd *ac = ap->cmds; ac != NULL; ac = ac->next) {
         if (ac->id == id) {
           aucmd_del(ac);
-          return true;
+          success = true;
         }
       }
     }
   }
-  return false;
+  return success;
 }
 
 // ===========================================================================

Original file line number	Diff line number	Diff line change
`@@ -2353,17 +2353,20 @@ int autocmd_delete_event(int group, event_T event, char_u *pat)`
`2353`	`2353`	`bool autocmd_delete_id(int64_t id)`
`2354`	`2354`	`{`
`2355`	`2355`	`assert(id > 0);`
	`2356`	`+ bool success = false;`
	`2357`	`+`
	`2358`	`+ // Note that since multiple AutoCmd objects can have the same ID, we need to do a full scan.`
`2356`	`2359`	`FOR_ALL_AUEVENTS(event) {`
`2357`	`2360`	`FOR_ALL_AUPATS_IN_EVENT(event, ap) {`
`2358`	`2361`	`for (AutoCmd *ac = ap->cmds; ac != NULL; ac = ac->next) {`
`2359`	`2362`	`if (ac->id == id) {`
`2360`	`2363`	`aucmd_del(ac);`
`2361`		`- return true;`
	`2364`	`+ success = true;`
`2362`	`2365`	`}`
`2363`	`2366`	`}`
`2364`	`2367`	`}`
`2365`	`2368`	`}`
`2366`		`- return false;`
	`2369`	`+ return success;`
`2367`	`2370`	`}`
`2368`	`2371`
`2369`	`2372`	`// ===========================================================================`