fix(PVS/V560): ignore false "conditional expression is always false" (#17830)

dundargoc · web-flow · commit d3af109d10b2 · 2022-03-24T06:25:20.000+08:00
"'qi' points to the global variable 'ql_info' or the window local location list stack 'wp->w_llist'. The contents of these structures can be changed out-of-band by an autocmd." vim/vim#9993 (comment)
diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c
@@ -2792,8 +2792,8 @@ static int qf_jump_edit_buffer(qf_info_T *qi, qfline_T *qf_ptr, int forceit, int
     return NOTDONE;
   }
 
-  if (old_qf_curlist != qi->qf_curlist
-      || old_changetick != qfl->qf_changedtick
+  if (old_qf_curlist != qi->qf_curlist  // -V560
+      || old_changetick != qfl->qf_changedtick  // -V560
       || !is_qf_entry_present(qfl, qf_ptr)) {
     if (qfl_type == QFLT_QUICKFIX) {
       emsg(_(e_current_quickfix_list_was_changed));
@@ -2894,7 +2894,7 @@ static int qf_jump_open_window(qf_info_T *qi, qfline_T *qf_ptr, bool newwin, int
     }
   }
   if (old_qf_curlist != qi->qf_curlist
-      || old_changetick != qfl->qf_changedtick
+      || old_changetick != qfl->qf_changedtick  // -V560
       || !is_qf_entry_present(qfl, qf_ptr)) {
     if (qfl_type == QFLT_QUICKFIX) {
       emsg(_(e_current_quickfix_list_was_changed));

Original file line number	Diff line number	Diff line change
`@@ -2792,8 +2792,8 @@ static int qf_jump_edit_buffer(qf_info_T qi, qfline_T qf_ptr, int forceit, int`
`2792`	`2792`	`return NOTDONE;`
`2793`	`2793`	`}`
`2794`	`2794`
`2795`		`- if (old_qf_curlist != qi->qf_curlist`
`2796`		`- \|\| old_changetick != qfl->qf_changedtick`
	`2795`	`+ if (old_qf_curlist != qi->qf_curlist // -V560`
	`2796`	`+ \|\| old_changetick != qfl->qf_changedtick // -V560`
`2797`	`2797`	`\|\| !is_qf_entry_present(qfl, qf_ptr)) {`
`2798`	`2798`	`if (qfl_type == QFLT_QUICKFIX) {`
`2799`	`2799`	`emsg(_(e_current_quickfix_list_was_changed));`
`@@ -2894,7 +2894,7 @@ static int qf_jump_open_window(qf_info_T qi, qfline_T qf_ptr, bool newwin, int`
`2894`	`2894`	`}`
`2895`	`2895`	`}`
`2896`	`2896`	`if (old_qf_curlist != qi->qf_curlist`
`2897`		`- \|\| old_changetick != qfl->qf_changedtick`
	`2897`	`+ \|\| old_changetick != qfl->qf_changedtick // -V560`
`2898`	`2898`	`\|\| !is_qf_entry_present(qfl, qf_ptr)) {`
`2899`	`2899`	`if (qfl_type == QFLT_QUICKFIX) {`
`2900`	`2900`	`emsg(_(e_current_quickfix_list_was_changed));`