fix(lsp): ensure pending changes are flushed on skipped debounce (#17015)

mfussenegger · web-flow · commit 3f2fbb824e89 · 2022-01-10T17:33:36.000+01:00
Follow up to #16881 Document changes could get sent out of order to the server: 1. on_lines: debounce > 0; add to pending changes; setup timer 2. on_lines: debounce = 0; send new changes immediately 3. timer triggers, sending changes from 1.
diff --git a/runtime/lua/vim/lsp.lua b/runtime/lua/vim/lsp.lua
@@ -413,8 +413,12 @@ do
         return
       end
       local state = state_by_client[client.id]
+      changetracking._reset_timer(state)
       local debounce = next_debounce(client.config.flags.debounce_text_changes or 150, state, bufnr)
       if debounce == 0 then
+        if state.pending_change then
+          state.pending_change()
+        end
         local changes = state.use_incremental_sync and incremental_changes(client) or full_changes()
         client.notify("textDocument/didChange", {
           textDocument = {
@@ -425,7 +429,6 @@ do
         })
         return
       end
-      changetracking._reset_timer(state)
       if state.use_incremental_sync then
         -- This must be done immediately and cannot be delayed
         -- The contents would further change and startline/endline may no longer fit
