fix(man.vim): ensure buftype=nofile after :tag or :stag #15675

zeertzjq · web-flow · commit 29bc648d2b25 · 2021-09-16T06:51:26.000-07:00
Problem: `buftype=help` occasionally propagates from help to man buffer. As a result the next time you open help it opens in the man window, replacing the manpage. Test case: nvim -u NORC :Man man :set bt? " should print `buftype=nofile` :help <C-W><C-W><C-W>c " go back to :Man window and close it :help " focus help window :Man man " open window with manpage again :set bt? " prints `buftype=help` Solution: - call s:set_options() - man#read_page() (called by autocmd BufReadCmd man://*) should already do this. But BufReadCmd doesn't fire for already-existing man:// buffers. Fix #15650
diff --git a/runtime/autoload/man.vim b/runtime/autoload/man.vim
@@ -58,6 +58,7 @@ function! man#open_page(count, mods, ...) abort
     else
       execute 'silent keepalt' a:mods 'stag' l:target
     endif
+    call s:set_options(v:false)
   finally
     call setbufvar(l:buf, '&tagfunc', l:save_tfu)
   endtry
