fix(lua): don't use nlua_error when exiting early

bfredl · bfredl · commit 147908336ec2 · 2022-03-07T11:04:36.000+01:00
Screen state is not initialized yet. Print directly to stderr instead.
diff --git a/src/nvim/lua/executor.c b/src/nvim/lua/executor.c
@@ -565,7 +565,8 @@ static bool nlua_init_packages(lua_State *lstate)
   lua_getglobal(lstate, "require");
   lua_pushstring(lstate, "vim._init_packages");
   if (nlua_pcall(lstate, 1, 0)) {
-      nlua_error(lstate, _("E5106: Error while loading packages: %.*s\n"));
+      mch_errmsg(lua_tostring(lstate, -1));
+      mch_errmsg("\n");
       return false;
   }
 
diff --git a/test/functional/lua/vim_spec.lua b/test/functional/lua/vim_spec.lua
@@ -1,6 +1,5 @@
 -- Test suite for testing interactions with API bindings
 local helpers = require('test.functional.helpers')(after_each)
-local isCI = require('test.helpers').isCI
 local Screen = require('test.functional.ui.screen')
 
 local funcs = helpers.funcs
@@ -2558,9 +2557,6 @@ describe('lua: builtin modules', function()
 
 
   it('does not work when disabled without runtime', function()
-    if isCI('sourcehut') then
-      pending('causes a core dump')
-    end
     clear{args={'--luamod-dev'}, env={VIMRUNTIME='fixtures/a'}}
     -- error checking could be better here. just check that --luamod-dev
     -- does anything at all by breaking with missing runtime..

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,8 @@ static bool nlua_init_packages(lua_State *lstate)`
`565`	`565`	`lua_getglobal(lstate, "require");`
`566`	`566`	`lua_pushstring(lstate, "vim._init_packages");`
`567`	`567`	`if (nlua_pcall(lstate, 1, 0)) {`
`568`		`- nlua_error(lstate, _("E5106: Error while loading packages: %.*s\n"));`
	`568`	`+ mch_errmsg(lua_tostring(lstate, -1));`
	`569`	`+ mch_errmsg("\n");`
`569`	`570`	`return false;`
`570`	`571`	`}`
`571`	`572`