Fix integration test CREATE USER statement (#1069)

bigmontz · web-flow · commit 426f6e5847db · 2023-03-30T15:13:07.000+02:00
The statement was failing in newer database version since minimum password length changed to 8.
Adjusting the password in the test fix the issue.

The drop user routine was also fixed since it can hide information about the original failure.
diff --git a/packages/neo4j-driver/test/rx/summary.test.js b/packages/neo4j-driver/test/rx/summary.test.js
@@ -16,7 +16,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import neo4j from '../../src'
+import neo4j, { Neo4jError } from '../../src'
 // eslint-disable-next-line no-unused-vars
 import RxSession from '../../src/session-rx'
 // eslint-disable-next-line no-unused-vars
@@ -344,15 +344,23 @@ describe('#integration-rx summary', () => {
       runnable = await session.beginTransaction().toPromise()
     }
 
+    let dropUser = true
+
     try {
       await verifySystemUpdates(
         runnable,
-        "CREATE USER foo SET PASSWORD 'bar'",
+        "CREATE USER foo SET PASSWORD 'barizon1'",
         {},
         1
       )
+    } catch (e) {
+      // the user should not be dropped if their creation fails
+      dropUser = !(e instanceof Neo4jError)
+      throw e
     } finally {
-      await verifySystemUpdates(runnable, 'DROP USER foo', {}, 1)
+      if (dropUser) {
+        await verifySystemUpdates(runnable, 'DROP USER foo', {}, 1)
+      }
     }
   }
 
