testkit: Fix Unknown request error path (#845)

bigmontz · web-flow · commit 213950cb4902 · 2022-01-20T17:01:16.000+01:00
There was two different errors during the unknown request error treatment.

First, the stringify function was not define in the LocalController scope. It get solve by extract this function to it own file and import it in the local.js.

Second, the backend was capturing the error in the `request` event and calling `writeBackendError` with the error object instead of the message.
diff --git a/packages/testkit-backend/src/backend.js b/packages/testkit-backend/src/backend.js
@@ -25,7 +25,7 @@ export default class Backend {
       try {
         this._controller.handle(contextId, request)
       } catch (e) {
-        this._channel.writeBackendError(contextId, e)
+        this._channel.writeBackendError(contextId, e.message)
       }
     })
   }
diff --git a/packages/testkit-backend/src/channel/testkit-protocol.js b/packages/testkit-backend/src/channel/testkit-protocol.js
@@ -1,5 +1,6 @@
 import readline from 'readline'
 import EventEmitter from 'events'
+import stringify from '../stringify'
 
 export default class Protocol extends EventEmitter {
   constructor (stream) {
@@ -61,7 +62,7 @@ export default class Protocol extends EventEmitter {
 
   serializeResponse (response) {
     console.log('> writing response', response)
-    const responseStr = this._stringify(response)
+    const responseStr = stringify(response)
     return  ['#response begin', responseStr, '#response end'].join('\n') + '\n'
   }
 
@@ -72,9 +73,4 @@ export default class Protocol extends EventEmitter {
     this.emit('request', { name, data })
   }
   
-  _stringify (val) {
-    return JSON.stringify(val, (_, value) =>
-      typeof value === 'bigint' ? `${value}n` : value
-    )
-  }
 }
diff --git a/packages/testkit-backend/src/controller/local.js b/packages/testkit-backend/src/controller/local.js
@@ -1,5 +1,6 @@
 import Context from '../context'
 import Controller from './interface'
+import stringify from '../stringify'
 
 
 /**
diff --git a/packages/testkit-backend/src/stringify.js b/packages/testkit-backend/src/stringify.js
@@ -0,0 +1,5 @@
+export default function stringify(json) {
+  return JSON.stringify(json, (_, value) =>
+    typeof value === 'bigint' ? `${value}n` : value
+  )
+}

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export default class Backend {`
`25`	`25`	`try {`
`26`	`26`	`this._controller.handle(contextId, request)`
`27`	`27`	`} catch (e) {`
`28`		`- this._channel.writeBackendError(contextId, e)`
	`28`	`+ this._channel.writeBackendError(contextId, e.message)`
`29`	`29`	`}`
`30`	`30`	`})`
`31`	`31`	`}`