CARVIEW |
Select Language
HTTP/2 200
date: Tue, 29 Jul 2025 18:04:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=367.402336,conversation_content-fragment;desc="conversation_content fragment";dur=705.609833,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=285.503646,nginx;desc="NGINX";dur=1.276766,glb;desc="GLB";dur=102.251703
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=wdfhjmhQxwg%2FU0NZazE%2FWB7MrT2yO1jQ1QFijIJeArXWoHLvtj4dpY2eOLk9z7SJDcdRSpmiQI%2FF%2FCIIrYWcu0haiUWU1NbH1R9rqaq%2B%2BT%2BcrrAKmZDhdPTvn5iTM47F%2BIXjauZn7uD7RV%2FqJ2j2zz48mAeeSmfMj7OOPyoFQ2GiHnGcME6uGGtPA8ESZ2lwpDlN5z%2FEmdnujohVTEKZ4kqCVzBZYTqBJQVMsAep5IZarRAWIPUWh%2B72vSJAMrs%2BI3vadKb3GaozPMqOY4yU0A%3D%3D--WbrJ4IgtgzVW2pyX--GlT83kY2WCXuRhnOM%2BqN1w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.539313920.1753812277; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 18:04:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 18:04:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AB32:319329:EE3EAA:119962A:68890D34
feat(object-mapping): support mapping types with restricted access by injectives · Pull Request #1668 · neo4j/neo4j-java-driver · GitHub
injectives
changed the title
draft
feat(object-mapping): support mapping types with restricted access
Jul 5, 2025
injectives
force-pushed
the
mapping
branch
4 times, most recently
from
July 7, 2025 09:21
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 156
feat(object-mapping): support mapping types with restricted access #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2bd2c9
to
feb02c6
Compare
MaxAake
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
The updated Object Mapping implementation attempts to make constructors with restricted access available to it. If successful, it considers them during the constructor search. However, it prefers constructors that are accessible by default when they have the same number of matched and mismatched properties. Given the objective of providing an easy and type-safe way of accessing user-defined values in `MapAccessor`, it would would sometimes to convenient to define the target type and map to it within the same method. For example: ```java record Movie(String title, String tagline, long released) {} var movies = driver.executableQuery("MATCH (movie:Movie) RETURN movie") .execute() .records() .stream() .map(record -> record.get("movie").as(Movie.class)) .toList(); ``` However, such Java `record` has restricted access from Object Mapping implementation perspective. This update makes it possible to map to such types. In addition, the following bugs have been fixed: - `null` type name was used in exception message when local `record` mapping failed - nonexistent properties were considered as matched on nodes and relationships
MaxAake
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✖️ 2️⃣
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jul 7, 2025
…eo4j#1668) The updated Object Mapping implementation attempts to make constructors with restricted access available to it. If successful, it considers them during the constructor search. However, it prefers constructors that are accessible by default when they have the same number of matched and mismatched properties. Given the objective of providing an easy and type-safe way of accessing user-defined values in `MapAccessor`, it would would sometimes to convenient to define the target type and map to it within the same method. For example: ```java record Movie(String title, String tagline, long released) {} var movies = driver.executableQuery("MATCH (movie:Movie) RETURN movie") .execute() .records() .stream() .map(record -> record.get("movie").as(Movie.class)) .toList(); ``` However, such Java `record` has restricted access from Object Mapping implementation perspective. This update makes it possible to map to such types. In addition, the following bugs have been fixed: - `null` type name was used in exception message when local `record` mapping failed - nonexistent properties were considered as matched on nodes and relationships
injectives
added a commit
that referenced
this pull request
Jul 8, 2025
…1668) (#1670) The updated Object Mapping implementation attempts to make constructors with restricted access available to it. If successful, it considers them during the constructor search. However, it prefers constructors that are accessible by default when they have the same number of matched and mismatched properties. Given the objective of providing an easy and type-safe way of accessing user-defined values in `MapAccessor`, it would would sometimes to convenient to define the target type and map to it within the same method. For example: ```java record Movie(String title, String tagline, long released) {} var movies = driver.executableQuery("MATCH (movie:Movie) RETURN movie") .execute() .records() .stream() .map(record -> record.get("movie").as(Movie.class)) .toList(); ``` However, such Java `record` has restricted access from Object Mapping implementation perspective. This update makes it possible to map to such types. In addition, the following bugs have been fixed: - `null` type name was used in exception message when local `record` mapping failed - nonexistent properties were considered as matched on nodes and relationships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The updated Object Mapping implementation attempts to make constructors with restricted access available to it. If successful, it considers them during the constructor search. However, it prefers constructors that are accessible by default when they have the same number of matched and mismatched properties.
Given the objective of providing an easy and type-safe way of accessing user-defined values in
MapAccessor
, it would would sometimes to convenient to define the target type and map to it within the same method. For example:However, such Java
record
has restricted access from Object Mapping implementation perspective. This update makes it possible to map to such types.In addition, the following bugs have been fixed:
null
type name was used in exception message when localrecord
mapping failed