keys should never return null #101

pontusmelke · 2015-12-18T11:01:30Z

For cypher statements that has no results, resultCurson.keys should return
an empty list rather than null.

For cypher statements that has no results, `resultCurson.keys` should return an empty list rather than `null`.

pontusmelke · 2015-12-18T11:02:25Z

driver/src/test/java/org/neo4j/driver/internal/InternalSessionTest.java

@@ -78,4 +78,34 @@ public void shouldBeAbleToOpenTxAfterPreviousIsClosed() throws Throwable
        // Then we should've gotten a transaction object back
        assertNotNull( tx );
    }
+
+    @Test
+    public void shouldNotBeAbleToUseSessionWhileOngoingTransaction() throws Throwable


These two tests has nothing to do with the fix, I just thought they were missing.

keys should never return null

keys should never return null

4f24ee9

For cypher statements that has no results, `resultCurson.keys` should return an empty list rather than `null`.

pontusmelke reviewed Dec 18, 2015
View reviewed changes

jakewins added a commit that referenced this pull request Dec 18, 2015

Merge pull request #101 from pontusmelke/null-keys

e3f423a

keys should never return null

jakewins merged commit e3f423a into neo4j:1.0 Dec 18, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

keys should never return null #101

keys should never return null #101

Uh oh!

pontusmelke commented Dec 18, 2015

Uh oh!

pontusmelke Dec 18, 2015

Uh oh!

Uh oh!

keys should never return null #101

keys should never return null #101

Uh oh!

Conversation

pontusmelke commented Dec 18, 2015

Uh oh!

pontusmelke Dec 18, 2015

Choose a reason for hiding this comment

Uh oh!

Uh oh!