Merge pull request #486 from technige/1.6-driver-logging

lutovich · web-flow · commit dda3e893401a · 2018-04-16T16:06:35.000+02:00
Better logging for Driver creation
diff --git a/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java b/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java
@@ -158,7 +158,10 @@ protected InternalDriver createDirectDriver( SecurityPlan securityPlan, BoltServ
     {
         ConnectionProvider connectionProvider = new DirectConnectionProvider( address, connectionPool );
         SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
-        return createDriver( securityPlan, sessionFactory, metrics, config );
+        InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
+        Logger log = config.logging().getLog( Driver.class.getSimpleName() );
+        log.info( "Direct driver instance %s created for server address %s", driver, address.toString() );
+        return driver;
     }
 
     /**
@@ -176,7 +179,10 @@ protected InternalDriver createRoutingDriver( SecurityPlan securityPlan, BoltSer
         ConnectionProvider connectionProvider = createLoadBalancer( address, connectionPool, eventExecutorGroup,
                 config, routingSettings );
         SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
-        return createDriver( securityPlan, sessionFactory, metrics, config );
+        InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
+        Logger log = config.logging().getLog( Driver.class.getSimpleName() );
+        log.info( "Routing driver instance %s created for server address %s", driver, address.toString() );
+        return driver;
     }
 
     /**
diff --git a/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java b/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java
@@ -47,7 +47,6 @@ public class InternalDriver implements Driver
         this.sessionFactory = sessionFactory;
         this.metrics = metrics;
         this.log = logging.getLog( Driver.class.getSimpleName() );
-        log.info( "Driver instance %s created", this );
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ public class InternalDriver implements Driver`
`47`	`47`	`this.sessionFactory = sessionFactory;`
`48`	`48`	`this.metrics = metrics;`
`49`	`49`	`this.log = logging.getLog( Driver.class.getSimpleName() );`
`50`		`- log.info( "Driver instance %s created", this );`
`51`	`50`	`}`
`52`	`51`
`53`	`52`	`@Override`