| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 01:14:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=437.784405,conversation_content-fragment;desc="conversation_content fragment";dur=899.615678,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=327.510006,nginx;desc="NGINX";dur=0.814641,glb;desc="GLB";dur=139.85673
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=6TsUhwY7nrxxIX6wwUpwEphwohbC09YDutXrn7IhiPfkkJBk0r9Vy9eAfTxDP1wXzxc0nw0gv%2FrCXS%2FjCggORekYTInY3zH4wUnzQyE5y0ucUaiM41MRnSenOMYfSpkJ%2BtnzKyxmL3iLsd9r%2BACr9XLm%2Fnv6RPk6w5hgRwynNL97eKAaOqMsE0F9%2BDMxCgnkIe0Mo47LbsTB4g9p%2FXZOZQ7ulZ%2BYsA6Qtg9ygFsRBHbW1%2By0Tr0Ebm1W57JukCuz90uTUT9FMWp1%2Fzb7DcUE9A%3D%3D--kaJ1eoWBx3ttezOs--nJ9%2Fx5Hdc4yB%2FBw0p09aEQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.997023056.1760145244; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 01:14:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 01:14:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 92E8:3FDFA5:1C5BE5:298D83:68E9AF5C
Fix various bugs causing hangs on Xunit by alexanderkyte · Pull Request #1654 · mono/mono · GitHub
alexanderkyte
force-pushed
the
xunit-fixes
branch
from
April 8, 2015 19:21
alexanderkyte
force-pushed
the
xunit-fixes
branch
2 times, most recently
from
April 20, 2015 18:00
alexanderkyte
force-pushed
the
xunit-fixes
branch
2 times, most recently
from
May 6, 2015 18:47
alexanderkyte
force-pushed
the
xunit-fixes
branch
from
May 13, 2015 23:00
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix various bugs causing hangs on Xunit #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work @alexanderkyte! I'm really looking forward to being able to run xunit 2.0 in Mono |
|
+1 to what @adamralph said hah. |
|
build |
|
I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds. Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic. |
alexanderkyte
force-pushed
the
xunit-fixes
branch
from
ac65914 to
cdc178a
Compare
alexanderkyte
force-pushed
the
xunit-fixes
branch
2 times, most recently
from
35027e3 to
8407588
Compare
|
build |
|
I'm seeing the error that has been haunting us on public jenkins arm for a while. |
This is a better fix for the problem of what type to give an object when the actual type can't be loaded in the current domain.
alexanderkyte
force-pushed
the
xunit-fixes
branch
2 times, most recently
from
300f0e7 to
7f898e1
Compare
When using a TransparentProxy, we run into the problem that the cache is shared between all marshalbyrefobjects. The fix here is to not update the cache when using a TransparentProxy, so that the correct slow path is used.
alexanderkyte
force-pushed
the
xunit-fixes
branch
from
7f898e1 to
b52f3de
Compare
…ixes, refactored
|
@kumpera I've updated the PR to bring the fixes to castclass, and extracted the caching behavior into a function. The indents look a bit absurd in a diff, but when in an editor where a tab is 8 spaces, as per the style guide, it's lined up. |
kumpera
added a commit
that referenced
this pull request
May 15, 2015
Fix various bugs causing hangs on Xunit
This was referenced Mar 23, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix various bugs causing hangs on Xunit Commit migrated from mono/mono@738acc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
No description provided.