| CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update redcarpet support to version 2 - take two #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Duplicate of #450 |
|
@tombell Ok, I didn't know. I've been waiting for fenced code blocks support in Jekyll for a year now. Would really like to get this landed. |
|
+1 |
|
+1 But Jekyll crashes with this update. [1] 80604 trace trap jekyll --server --autoI found a similar bug report with pygments. |
|
Passes all tests in the test suite. Where did it crash, and doing what? |
|
Maybe the bug comes from pygments.rb. I have created a sample project. It runs normally if I only use
If I remove all source code from the file it works very well. So I think it's a pygments.rb problem. I use Mac OSX 10.8.2 + Ruby 1.9.3p194. |
|
Can you show me what you're trying to render, because as I said, the tests pass when I wrote it. |
|
This file: It's from octopress's repo. |
|
Looks like it is a pygments.rb problem, think we'll have to see if that is updated. It's not been touched in 3 months, so we'll see. |
|
Looks like the bug has been fixed in the latest pygments.rb. Hope this pull request can be merged. |
|
+1 |
This prevents an exception if something like the following is used:
~~~ {foo bar}
some code
~~~
|
This should be ready to 🤘 if anyone wants to test it with their jekyll site. |
|
Wow, exactly what I was looking for. The last step for storing my site on github was making the syntax highlighting work on the site and on github. Just tried it out and it works nicely with the backticks. Readable both on the ouputed html and on github: example - also, nice that the liquid highlight keeps working. I'm not too familiar with ruby - so not sure if there's a better way to try it out, here's what I did: git clone https://github.com/tombell/jekyll.git
cd jekyll
git checkout redcarpet-update
gem build jekyll.gemspec
gem install jekyll-0.11.2.gem
# now the bin is ready to use
sudo ln -s ~/git/jekyll/bin/jekyll /usr/local/bin/jekyll@mojombo - +10 for this PR @tombell - awesome! |
|
Just a small note to anybody coming here and then listening to the duplicate comment thus ending up using #450. 450 will break your specs even though it works, so it might be better to stick with this one if this author intends to make sure specs pass. |
|
@mojombo yeah! |
|
@mojombo What do you think about cherry-picking https://github.com/chitsaou/jekyll/commit/43ee477c0b0c5e2f0e618ae75473cb622badc9a1 from #450? SmartyPants support in Redcarpet would be nice to have. cc @chitsaou |
|
This has SmartyPants support if you add the |
|
Ah, correct, it's right here. My apologies. |
|
Do you have extensions: [fenced_code_blocks] underneath redcarpet in your
|
|
Oh, I'll try that out! I didn't think I needed any extensions/options with Thanks On Wed, Mar 6, 2013 at 1:44 PM, Jupiter St John notifications@github.comwrote:
– Zachary Kain Designer, Creative Technologist |
Update redcarpet support to v2.