You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.
Description of the Change
This is a documentation only change.
I couldn't find any reference to describe not supporting an async callback. It seems like a natural conclusion to draw, given mocha specializes in async tests, and given it and hook do.
I spent considerable time trying to figure out why an async test was failing in one of my modules before I discovered the reason deep in an issue discussion (#2975 (comment))!
Alternate Designs
Why should this be in core?
This is a documentation change.
Benefits
I hope that this helps others design their test suites (I saw a number of comments about spending 'lots of time' trying to figure this out).
I couldn't find any reference to `describe` not supporting an async function. It seems like a natural idea given `it` and `before` do.
I spent considerable time trying to figure out why an async test was failing before I discovered the reason deep in an issue discussion (#2975 (comment)), so hope that this helps others design their test suites!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This is a documentation only change.
I couldn't find any reference to
describe
not supporting an async callback. It seems like a natural conclusion to draw, given mocha specializes in async tests, and givenit
and hook do.I spent considerable time trying to figure out why an async test was failing in one of my modules before I discovered the reason deep in an issue discussion (#2975 (comment))!
Alternate Designs
Why should this be in core?
This is a documentation change.
Benefits
I hope that this helps others design their test suites (I saw a number of comments about spending 'lots of time' trying to figure this out).
Possible Drawbacks
Applicable issues