| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 10:58:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=324.215859,conversation_content-fragment;desc="conversation_content fragment";dur=879.468061,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=212.761147,nginx;desc="NGINX";dur=1.216101,glb;desc="GLB";dur=145.486998
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=tkuQuknZkZr6GxTEY4TL7vADXuyNWSbDaxrBvIxxi%2FeG%2FqSCJZQ1RkAs2RwFm9mqVHOquQlJLhqy4%2BbfKYdtJAhHlC4offk8s4hEZharzKmXUDXMLmBSmdGrQ4EWxnQVQwM1hlF7BQVhmJHB8qKcVJLmOjrhnEylGcsDvUAQGrs9SJyfJ1NVWNCdup0A8GUAYnlHi%2BtSiVMv1uBgOq7YSk6qpDvbpQqyeoQcuG4K%2FJSpEHctBvZcrkVLc3grr6l18fl9nM5VUgU67Vv7kZ03WQ%3D%3D--FE0qy%2F6pyp2%2FgxtY--4QlX6j%2BdvuA6AZ80ZB8BcQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.170264881.1760093921; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 10:58:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 10:58:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C0CA:35308D:189DD6D:1D57AF2:68E8E6E1
Add support for new escape sequences and Python compatible rendering by mitsuhiko · Pull Request #804 · mitsuhiko/minijinja · GitHub
mitsuhiko
changed the title
Add support for hexadecimal and octal escape sequences in string literals
Add support for new escape sequences and Python compatible rendering
Jun 8, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 131
Add support for new escape sequences and Python compatible rendering #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mitsuhiko
wants to merge
4
commits into
main
Choose a base branch
from
string-escapes-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rals Implements \xNN (hexadecimal) and \NNN (octal) escape sequences to match Jinja2 compatibility. The \0 sequence is now handled as part of the octal system for consistency. Fixes #803 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Make clippy happy
Adds an optional pycompat_rendering flag to Environment that enables rendering values in a format compatible with Python Jinja2: - `true`/`false` render as `True`/`False` - `none` renders as `None` - Strings use Python-style escaping and quoting This addresses compatibility issues for SQL templating and other use cases where precise output format matters. The feature is disabled by default to maintain backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mitsuhiko
commented
Jun 7, 2025
| fn test_pycompat_rendering_complex_case() { | ||
| let mut env = Environment::new(); | ||
|
|
||
| // Test the specific case from the issue: {{ [true, false, none, 'foo', "bar'baz", '\x13'] }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment disagrees with the test implementation below.
| @@ -0,0 +1,72 @@ | |||
| use minijinja::{context, Environment}; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really don't need this example here.
mitsuhiko
commented
Jun 7, 2025
minijinja/src/utils.rs
Outdated
| } | ||
|
|
||
| fn parse_hex_byte(&self, chars: &mut Chars) -> Result<u8, Error> { | ||
| let hexnum = chars.chain(repeat('\0')).take(2).collect::<String>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably error if the sequence is just \x1
mitsuhiko
changed the title
|
I'm going to merge part one of it in a separate PR: #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Implements \xNN (hexadecimal) and \NNN (octal) escape sequences to match Jinja2 compatibility. The \0 sequence is now handled as part of the octal system for consistency.
This was made with Claude Code for this video: https://www.youtube.com/watch?v=sQYXZCUvpIc
Fixes #803
Fixes #785
🤖 Generated with Claude Code