Merge pull request #248181 from gabritto/hoverlimit

mjbvz · web-flow · commit 7ef9cdd258d2 · 2025-05-15T08:50:54.000-07:00
[typescript-language-features] Add configuration for maximum hover length
diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json
@@ -466,6 +466,12 @@
             "tags": [
               "experimental"
             ]
+          },
+          "js/ts.hover.maximumLength": {
+            "type": "number",
+            "default": 500,
+            "description": "%configuration.hover.maximumLength%",
+            "scope": "resource"
           }
         }
       },
diff --git a/extensions/typescript-language-features/package.nls.json b/extensions/typescript-language-features/package.nls.json
@@ -226,6 +226,7 @@
 	"configuration.tsserver.nodePath": "Run TS Server on a custom Node installation. This can be a path to a Node executable, or 'node' if you want VS Code to detect a Node installation.",
 	"configuration.updateImportsOnPaste": "Automatically update imports when pasting code. Requires TypeScript 5.6+.",
 	"configuration.expandableHover": "Enable expanding/contracting the hover to reveal more/less information from the TS server. Requires TypeScript 5.9+.",
+	"configuration.hover.maximumLength": "The maximum number of characters in a hover. If the hover is longer than this, it will be truncated. Requires TypeScript 5.9+.",
 	"walkthroughs.nodejsWelcome.title": "Get started with JavaScript and Node.js",
 	"walkthroughs.nodejsWelcome.description": "Make the most of Visual Studio Code's first-class JavaScript experience.",
 	"walkthroughs.nodejsWelcome.downloadNode.forMacOrWindows.title": "Install Node.js",
diff --git a/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts b/extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts
@@ -208,6 +208,8 @@ export default class FileConfigurationManager extends Disposable {
 			includeCompletionsForModuleExports: config.get<boolean>('suggest.autoImports'),
 			...getInlayHintsPreferences(config),
 			...this.getOrganizeImportsPreferences(preferencesConfig),
+			// @ts-expect-error until TS 5.9
+			maximumHoverLength: this.getMaximumHoverLength(document),
 		};
 
 		return preferences;
@@ -257,6 +259,16 @@ export default class FileConfigurationManager extends Disposable {
 			} : {}),
 		};
 	}
+
+
+	private getMaximumHoverLength(document: vscode.TextDocument): number {
+		const defaultMaxLength = 500;
+		const maximumHoverLength = vscode.workspace.getConfiguration('js/ts', document).get<number>('hover.maximumLength', defaultMaxLength);
+		if (!Number.isSafeInteger(maximumHoverLength) || maximumHoverLength <= 0) {
+			return defaultMaxLength;
+		}
+		return maximumHoverLength;
+	}
 }
 
 function withDefaultAsUndefined<T, O extends T>(value: T, def: O): Exclude<T, O> | undefined {

Original file line number	Diff line number	Diff line change
`@@ -466,6 +466,12 @@`
`466`	`466`	`"tags": [`
`467`	`467`	`"experimental"`
`468`	`468`	`]`
	`469`	`+ },`
	`470`	`+ "js/ts.hover.maximumLength": {`
	`471`	`+ "type": "number",`
	`472`	`+ "default": 500,`
	`473`	`+ "description": "%configuration.hover.maximumLength%",`
	`474`	`+ "scope": "resource"`
`469`	`475`	`}`
`470`	`476`	`}`
`471`	`477`	`},`