You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @saschanaz
I have switched the old functions to async, but the new function is still sync because the emitter is not async. I tried switching it to async, but it broke.
Technically we still have events, but adding comments there would be a bit awkward as that would only work for onevent attributes and not for addEventListener calls. Probably fair to just skip that.
Hello @jakebailey
First of all, thank you very much for merging this pr.
Secondly, I think we can improve the compiler's speed by caching comments in a JSON file, which will serve as the comments reference. The GitHub action will be responsible for updating it. If this sound good to you, I can draft a pr for it and compare the speed.
Also, there are still some missing comments.
I don't know what you mean, sorry. The comments have to be in a declaration file. Moving them elsewhere won't speed things up (and will make the compiler/editor stuff challenging).
I don't know what you mean, sorry. The comments have to be in a declaration file. Moving them elsewhere won't speed things up (and will make the compiler/editor stuff challenging).
I mean instead of fetching the data each time you run the generate command, we can put the comments in a json file and the builder will use that json file instead of fetching the summaries every time
I am pretty sure Jake meant the usage (in the editor and compile of user code) of the generated files will slow down the typescript compiler as it has to parse more data.
Build/generation time of these files is uninteresting.
tsdoc belongs into the .d.ts file and not in a (faster?) parallel world which needs to be invented and maintained.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1940
Hello:)
In my last PR I have used MDN to generate comments for interface declarations, in this pr I add it for the properties.