You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we send configFileDiag when its a new program.
The need to add "skip" for this is because we have heuristics on when and how to send the configFileDiag when we open file so those operations just call with skip and do there own thing..
The main issue when looking into wsl2 repro was that when file is deleted:
file Delete event for that specific file is observed. and marked
file delete and add in the config file's folder is observed but on "linux' or "wsl2" it is delayed so we can send that event in batches.
Project gets updated as part of editor sending request to open file for renamed file with the new name - at this point the project only observes that old file name is deleted but because the wild card directory watcher is not invoked which updates root file names the root file names still contain old file name, So we sends configFileDiag that translates into vscode showing error: "missing old file"
The timer for updating directory watcher runs and sends event for updating root file names of the config file
We update the project and have no errors but without this fix we could never report that to vscode since its only reported when tsconfig reloads or new file opens and doesnt belong to project. Result stale error in the editor. With this change, at this project update we will send configFileDiag to vscode and this should clear the errors for the project. displayed
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we send configFileDiag when its a new program.
The need to add "skip" for this is because we have heuristics on when and how to send the configFileDiag when we open file so those operations just call with
skip
and do there own thing..The main issue when looking into wsl2 repro was that when file is deleted:
Fixes #57340