DO NOT MERGE: Show synthesized triple slash references in diagnostics for top200 analysis #57569

error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- src/batteries.ts#L6
error TS18055: Declaration file contains synthesized type reference directives: '"node"'

discordjs/discord.js

40 of 62 projects failed to build with the old tsc and were ignored

packages/brokers/tsconfig.docs.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- packages/brokers/src/brokers/redis/RPCRedis.ts#L1

packages/brokers/tsconfig.eslint.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- packages/brokers/src/brokers/redis/RPCRedis.ts#L1

packages/brokers/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- packages/brokers/src/brokers/redis/RPCRedis.ts#L1

packages/formatters/tsconfig.docs.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/formatters/src/formatters.ts#L1

packages/formatters/tsconfig.eslint.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/formatters/src/formatters.ts#L1

packages/formatters/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/formatters/src/formatters.ts#L1

Eugeny/tabby

9 of 29 projects failed to build with the old tsc and were ignored

tabby-core/tsconfig.typings.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'

tabby-terminal/tsconfig.typings.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'

facebook/lexical

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

freeCodeCamp/freeCodeCamp

8 of 12 projects failed to build with the old tsc and were ignored

tools/ui-components/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

FuelLabs/fuels-ts

12 of 48 projects failed to build with the old tsc and were ignored

packages/crypto/tsconfig.dts.json

error TS18055: Declaration file contains synthesized type reference directives: '"web", "node"'
- packages/crypto/src/browser/crypto.ts#L1

packages/crypto/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"web", "node"'
- packages/crypto/src/browser/crypto.ts#L1

packages/math/tsconfig.dts.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/math/src/bn.ts#L1

packages/math/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/math/src/bn.ts#L1

packages/fuels/tsconfig.dts.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/fuels/src/cli/commands/dev/autoStartFuelCore.ts#L1

homebridge/homebridge

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- src/util/mac.ts#L1

immich-app/immich

5 of 8 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node"'
- server/src/domain/repositories/storage.repository.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"multer"'
error TS18055: Declaration file contains synthesized type reference directives: '"multer", "node"'
- server/src/immich/interceptors/file-upload.interceptor.ts#L1

server/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node"'
- server/src/domain/repositories/storage.repository.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"multer"'
error TS18055: Declaration file contains synthesized type reference directives: '"multer", "node"'
- server/src/immich/interceptors/file-upload.interceptor.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'

ionic-team/ionic-framework

20 of 21 projects failed to build with the old tsc and were ignored

core/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- core/src/utils/test/platform.utils.ts#L1

jhipster/generator-jhipster

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.types.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'

makeplane/plane

6 of 8 projects failed to build with the old tsc and were ignored

packages/editor/core/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/editor/core/src/ui/mentions/mention-list.tsx#L1

packages/ui/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/ui/src/dropdowns/helper.tsx#L2
- packages/ui/src/hooks/use-dropdown-key-down.tsx#L1

typescript-bot · 2024-02-28T00:48:23Z

@andrewbranch Here are some more interesting changes from running the top-repos suite

Details

marmelab/react-admin

25 of 26 projects failed to build with the old tsc and were ignored

packages/ra-core/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
error TS18055: Declaration file contains synthesized type reference directives: '"lodash"'
- packages/ra-core/src/form/validate.ts#L1

nextauthjs/next-auth

16 of 40 projects failed to build with the old tsc and were ignored

packages/adapter-pouchdb/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"pouchdb-find", "pouchdb-core", "pouchdb-mapreduce", "pouchdb-replication"'
- packages/adapter-pouchdb/src/index.ts#L18

nextui-org/nextui

2 of 75 projects failed to build with the old tsc and were ignored

packages/core/system-rsc/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/core/system-rsc/src/types.ts#L5

packages/core/system/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/core/system/src/provider.tsx#L1

packages/hooks/use-aria-press/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/hooks/use-aria-press/src/dom-helpers.ts#L1

packages/components/button/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/button/src/button-group-context.ts#L1
- packages/components/button/src/use-button-group.ts#L1

packages/components/avatar/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/avatar/src/avatar-group-context.ts#L1
- packages/components/avatar/src/use-avatar.ts#L1

packages/components/accordion/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/accordion/src/use-accordion-item.ts#L1

packages/hooks/use-data-scroll-overflow/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/hooks/use-data-scroll-overflow/src/index.ts#L1

packages/components/scroll-shadow/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/scroll-shadow/src/use-scroll-shadow.ts#L1

packages/components/listbox/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/listbox/src/base/listbox-section-base.tsx#L1
- packages/components/listbox/src/use-listbox-item.ts#L1

packages/components/code/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/code/src/use-code.ts#L1

packages/components/link/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/link/src/use-link.ts#L1

packages/components/card/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/card/src/card-context.ts#L1

packages/components/popover/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/popover/src/popover-context.ts#L1

packages/hooks/use-infinite-scroll/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/hooks/use-infinite-scroll/src/index.ts#L1

packages/components/menu/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/menu/src/base/menu-section-base.tsx#L1
- packages/components/menu/src/use-menu-item.ts#L1

packages/components/dropdown/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/dropdown/src/dropdown-context.ts#L1
- packages/components/dropdown/src/dropdown-trigger.tsx#L1

packages/components/checkbox/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/checkbox/src/checkbox-group-context.ts#L1
- packages/components/checkbox/src/use-checkbox-group.ts#L1

packages/components/kbd/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/kbd/src/use-kbd.ts#L1

packages/hooks/use-callback-ref/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/hooks/use-callback-ref/src/index.ts#L5

packages/components/modal/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/modal/src/modal-context.ts#L1

packages/hooks/use-scroll-position/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/hooks/use-scroll-position/src/index.ts#L1

packages/components/navbar/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

packages/components/progress/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/progress/src/use-circular-progress.ts#L1
- packages/components/progress/src/use-progress.ts#L1

packages/components/radio/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/components/radio/src/radio-group-context.ts#L1
- packages/components/radio/src/use-radio-group.ts#L1

packages/components/table/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

prisma/prisma

82 of 120 projects failed to build with the old tsc and were ignored

packages/get-platform/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/get-platform/src/getPlatform.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- packages/get-platform/src/test-utils/jestContext.ts#L1

packages/engines/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/get-platform/src/getPlatform.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- packages/get-platform/src/test-utils/jestContext.ts#L1

packages/cli/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- packages/get-platform/src/test-utils/jestContext.ts#L1

packages/client/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- packages/get-platform/src/test-utils/jestContext.ts#L1

pubkey/rxdb

8 of 11 projects failed to build with the old tsc and were ignored

config/tsconfig.types.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- src/plugins/replication-webrtc/signaling-server.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"mocha"'
- src/plugins/test-utils/config.ts#L2

puppeteer/puppeteer

7 of 14 projects failed to build with the old tsc and were ignored

packages/testserver/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- packages/testserver/src/index.ts#L7 in packages/testserver/tsconfig.json

test/installation/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- test/installation/src/sandbox.ts#L6 in test/installation/tsconfig.json
- test/installation/src/util.ts#L7 in test/installation/tsconfig.json

react-bootstrap/react-bootstrap

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

react-navigation/react-navigation

1 of 14 projects failed to build with the old tsc and were ignored

packages/native/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/native/src/useBackButton.tsx#L1 in packages/native/tsconfig.build.json

packages/elements/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

packages/react-native-drawer-layout/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/react-native-drawer-layout/src/types.tsx#L1 in packages/react-native-drawer-layout/tsconfig.build.json

packages/drawer/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/drawer/src/types.tsx#L1 in packages/drawer/tsconfig.build.json

packages/native-stack/tsconfig.build.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- packages/native-stack/src/types.tsx#L1 in packages/native-stack/tsconfig.build.json

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

ReactiveX/rxjs

11 of 15 projects failed to build with the old tsc and were ignored

packages/rxjs/src/tsconfig.types.json

error TS18056: Declaration file contains synthesized file reference directives: '"operators/index.d.ts", "testing/index.d.ts"'
- packages/rxjs/src/index.ts#L16 in packages/rxjs/src/tsconfig.types.json

recharts/recharts

demo/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"lodash", "react"'

redis/node-redis

packages/client/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- packages/client/lib/client/commands-queue.ts#L1
- packages/client/lib/cluster/cluster-slots.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node"'
- packages/client/lib/client/socket.ts#L1

Redocly/redoc

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

tsconfig.lib.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'

tailwindlabs/headlessui

1 of 5 projects failed to build with the old tsc and were ignored

packages/@headlessui-react/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"react"'
error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- packages/@headlessui-react/src/test-utils/suppress-console-logs.ts#L1

typescript-bot · 2024-02-28T00:48:24Z

@andrewbranch Here are some more interesting changes from running the top-repos suite

Details

typeorm/typeorm

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node", "node", "node", "node", "node"'
- src/driver/mongodb/typings.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node"'
- src/platform/PlatformTools.ts#L1

usablica/intro.js

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"jest"'
- tests/jest/helper.ts#L1

vadimdemedes/ink

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node", "node"'
- src/components/App.tsx#L1
error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- src/components/AppContext.ts#L1
- src/components/FocusContext.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"node", "react"'
- src/components/StderrContext.ts#L1
- src/components/StdoutContext.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "react"'
- src/components/StdinContext.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"node"'
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node", "node"'
- src/render.ts#L1

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- app/auto-updater-linux.ts#L1 in app/tsconfig.json
error TS18055: Declaration file contains synthesized type reference directives: '"node", "node", "node", "node"'
- app/session.ts#L1 in app/tsconfig.json

vercel/swr

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS18056: Declaration file contains synthesized file reference directives: '"../../../env.d.ts"'
- src/core/index.ts#L1
error TS18055: Declaration file contains synthesized type reference directives: '"react"'
- src/index/config.ts#L1

vuetifyjs/vuetify

3 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

error TS18055: Declaration file contains synthesized type reference directives: '"cypress"'
- packages/vuetify/cypress/templates/generateStories.tsx#L5

packages/vuetify/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"cypress"'
- packages/vuetify/cypress/templates/generateStories.tsx#L5

web3/web3.js

55 of 63 projects failed to build with the old tsc and were ignored

packages/web3-types/tsconfig.types.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/web3-types/src/web3_base_provider.ts#L17

youzan/vant

3 of 10 projects failed to build with the old tsc and were ignored

packages/vant-cli/site/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/vant-cli/src/compiler/compile-css.ts#L1
- packages/vant-cli/src/compiler/web-types/type.ts#L1

packages/vant-cli/tsconfig.json

error TS18055: Declaration file contains synthesized type reference directives: '"node"'
- packages/vant-cli/src/compiler/compile-css.ts#L1
- packages/vant-cli/src/compiler/web-types/type.ts#L1

jakebailey · 2024-02-28T00:50:48Z

Quite surprised about react showing up that much, given the files I opened all contained an import of react anyway...

dragomirtitian · 2024-02-28T15:39:19Z

Quite surprised about react showing up that much, given the files I opened all contained an import of react anyway...

Yes that is really surprising. For path references there is code that specifically excludes references to imported files. Guess for type reference directives that logic is missing:

https://github.com/microsoft/TypeScript/blob/main/src/compiler/transformers/declarations.ts#L580-L586

if (exportedModulesFromDeclarationEmit?.includes(file.symbol)) {
    // Already have an import declaration resolving to this file
    return;
}

andrewbranch · 2024-02-28T18:26:50Z

Looking at these, I don’t feel too worried about the volume of real-world breaks being very high. The only thing I might send a preemptive PR for is adding an explicit reference to "../../env.d.ts" to vercel/swr. That said, knowing you need to do that still feels like a footgun. swr’s tsconfig.json explicitly includes env.d.ts. That could be considered bad practice now, as it sets up a program graph that a library consumer would never have. Libraries should probably set their files array to be just their package.json entrypoints. But even that’s unrealistic, since a consumer might not load all entrypoints. Ideally, you’d want to make sure your library code compiles when setting each package.json entrypoint as the lone tsconfig.json files entry. But nobody is going to do that.

Show synthesized triple slash references in diagnostics for analysis

2b69c9f

typescript-bot assigned andrewbranch Feb 27, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 27, 2024

andrewbranch mentioned this pull request Mar 6, 2024

DO NOT MERGE: Show preserved triple slash references in diagnostics for top200 analysis #57656

Closed

jakebailey mentioned this pull request Mar 20, 2024

Do not perserve references in declaration emit, unless preserve=true #57681

Merged

andrewbranch closed this Mar 20, 2024

DO NOT MERGE: Show synthesized triple slash references in diagnostics for top200 analysis #57569

DO NOT MERGE: Show synthesized triple slash references in diagnostics for top200 analysis #57569

Uh oh!

Conversation

andrewbranch commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbranch commented Feb 27, 2024

Uh oh!

typescript-bot commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2024

Uh oh!

typescript-bot commented Feb 28, 2024

Uh oh!

typescript-bot commented Feb 28, 2024

Uh oh!

jakebailey commented Feb 28, 2024

Uh oh!

dragomirtitian commented Feb 28, 2024

Uh oh!

andrewbranch commented Feb 28, 2024

andrewbranch commented Feb 27, 2024 •

edited

Loading

typescript-bot commented Feb 27, 2024 •

edited

Loading