You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add directly referenced project's root files to the auto import provider if "paths" are setup in options which kind of indicates willingness to use module resolution
Allow auto import if paths is present in options or symlink cache has any symlinks discovered (as part of say calculating auto import root names)
We also could get info from opened referenced project instead of adding to auto import provider but I wanted to first check if we want something like this which understands referenced project or not before adding anything more to this experiment
sheetalkamat
changed the title
Some tweaking to handle project references for auto import
[Experiment] Some tweaking to handle project references for auto import
Oct 3, 2023
We also could get info from opened referenced project instead of adding to auto import provider
This was the approach I took in #47690 which ended up being problematic for the export info and module specifier caches. I forgot about this distinction when we talked the other day. I think using the AutoImportProvider is slightly less efficient but avoids these caching pitfalls, and is overall a more promising approach. I spent a little while trying to break the export info cache invalidation on this branch and it looked good. That said, exportMapCache.ts and moduleSpecifierCache.ts could be updated to exercise this new functionality.
@andrewbranch i had missed the editor services to update to check for same flag when i first pushed commit .. didn’t realize you already looked at it or I would I have made separate commit .. i will also add a test when that option is not set in host preferences just for completeness when I get to desk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55879