Automatically create sort groups based on newlines in organize imports #48330

MQuy · 2022-03-19T00:20:46Z

Based on @RyanCavanaugh's suggestion #41494 (comment)

when organizing imports in each block of newline-contiguous

import c from "C";
import d from "D";
import a from "A";
import b from "B";

turns into

import c from "C";
import a from "A";
import b from "B";
import d from "D";

jakebailey

This looks about right to me, but I think what I'd like to see are a few more tests to cover cases where there are comments, e.g., what is the behavior when we have something like:

// polyfill
import "lib"
// not polyfill
import { b } from "lib2"

or say

import "lib" // xyz
import c from "C"

Or similar (this isn't exhaustive). I know the original issue had some code snippets that feature comments.

src/services/organizeImports.ts

tests/baselines/reference/organizeImports/TopLevelAndAmbientModule.ts

src/services/organizeImports.ts

tests/cases/fourslash/organizeImportsGroup_MultiNewlines.ts

src/services/organizeImports.ts

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

src/services/organizeImports.ts

This comment was marked as outdated.

Sign in to view

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 19, 2022

MQuy mentioned this pull request Mar 19, 2022

Feature request: disable organize import on specific lines #41494

Closed

Create sort groups based on newlines

b89f697

MQuy force-pushed the feature/create-sort-groups-by-newlines branch from ff8df38 to b89f697 Compare March 19, 2022 00:38

Update ambient module test to match with new sort groups

ef6c7db

sandersn requested review from jakebailey and RyanCavanaugh March 28, 2022 15:22

sandersn assigned jakebailey Mar 28, 2022

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 28, 2022

jakebailey requested changes Mar 28, 2022

View reviewed changes

Use for of to make code shorter and shorten argument

fa83bce

jakebailey reviewed Mar 28, 2022

View reviewed changes

src/services/organizeImports.ts Outdated Show resolved Hide resolved

MQuy added 2 commits March 28, 2022 21:17

Sort import based on newlin eand comments

141f9ee

Add import group tests for newline and comments

c22b697

jakebailey reviewed Mar 28, 2022

View reviewed changes

tests/cases/fourslash/organizeImportsGroup_MultiNewlines.ts Show resolved Hide resolved

Remove SortComments test and fix organizeImport6

2c13fec

MQuy force-pushed the feature/create-sort-groups-by-newlines branch from fd96817 to 2c13fec Compare March 28, 2022 21:08

jakebailey reviewed Mar 30, 2022

View reviewed changes

src/services/organizeImports.ts Outdated Show resolved Hide resolved

src/services/organizeImports.ts Outdated Show resolved Hide resolved

jakebailey reviewed Apr 5, 2022

View reviewed changes

src/services/organizeImports.ts Outdated Show resolved Hide resolved

MQuy force-pushed the feature/create-sort-groups-by-newlines branch from aa759f0 to 24e4cd9 Compare April 5, 2022 17:46

Rename isNewGroup and reuse scanner

bd8ce22

MQuy force-pushed the feature/create-sort-groups-by-newlines branch from f594067 to bd8ce22 Compare April 5, 2022 18:03

jakebailey reviewed Apr 5, 2022

View reviewed changes

src/services/organizeImports.ts Outdated Show resolved Hide resolved

Update src/services/organizeImports.ts

eee44b5

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

jakebailey reviewed Apr 5, 2022

View reviewed changes

src/services/organizeImports.ts Outdated Show resolved Hide resolved

Fix code format

f61a657

jakebailey approved these changes Apr 5, 2022

View reviewed changes

jakebailey merged commit 6e0447f into microsoft:main Apr 5, 2022

DanielRosenwasser changed the title ~~[Feature] - Automatically create sort groups based on newlines~~ Automatically create sort groups based on newlines in organize imports Apr 6, 2022

FredKSchott mentioned this pull request Apr 7, 2022

format and organize imports on main auto-formatter withastro/astro#3013

Closed

EvitanRelta mentioned this pull request Jun 12, 2022

Importing customCss after githubMarkdownCss files & and removing !important EvitanRelta/markgh#21

Closed

jakebailey mentioned this pull request Feb 6, 2023

Convert debug namespace into a module, direct import #51455

Closed

jakebailey mentioned this pull request Jul 10, 2023

Organize imports should remove blank lines within imports #22914

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Automatically create sort groups based on newlines in organize imports #48330

Automatically create sort groups based on newlines in organize imports #48330

MQuy commented Mar 19, 2022 •

edited by jakebailey

Loading

Uh oh!

This comment was marked as outdated.

jakebailey left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Automatically create sort groups based on newlines in organize imports #48330

Automatically create sort groups based on newlines in organize imports #48330

Conversation

MQuy commented Mar 19, 2022 • edited by jakebailey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MQuy commented Mar 19, 2022 •

edited by jakebailey

Loading