| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 18 Jul 2025 21:44:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=354.872489,conversation_content-fragment;desc="conversation_content fragment";dur=705.528089,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=357.447591,nginx;desc="NGINX";dur=0.726573,glb;desc="GLB";dur=96.133668
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Fa2P%2F1haa16SynG92L%2B%2FM6me2TYfKglriTTM9lgS8ag%2BNacAQxF41rLmNPiWd6nSQ5QNoxs%2FzUWRoq%2Bs78y66l%2Fsro%2B%2FthYuiprdjKmLjrDjP7O4WmQ1EW9N9vQZ6ONEMXRpXL51j1kiiWJtlBz92tMdm5aNMdLwMYSMTSATjIGST%2Fkieq6bFk5wx1WH7sJy%2BstcqLiMSJ6QYnUseHw8zaW85KZvC7EUObzM0CvZE0ssuvqTWNbdat2rRzc91sezzR%2BoVk%2BwEgqJLFURGQ86JQ%3D%3D--c87c7qnYdYa%2Ff90y--M%2BN16NRjRSMmW8tUv8hb%2Fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1982651406.1752875041; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 21:44:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 21:44:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DDF2:3001CD:1AC06D:234254:687AC021
Add 12 more grammar errors by sandersn · Pull Request #47075 · microsoft/TypeScript · GitHub
typescript-bot
added
Author: Team
For Uncommitted Bug
PR for untriaged, rejected, closed or missing bug
labels
Dec 8, 2021
sandersn
requested review from
andrewbranch,
amcasey and
DanielRosenwasser
and removed request for
andrewbranch
December 8, 2021 23:24
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Add 12 more grammar errors #47075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add 12 more grammar errors #47075
+477
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sandersn
requested review from
andrewbranch,
amcasey and
DanielRosenwasser
and removed request for
andrewbranch
andrewbranch
reviewed
Dec 8, 2021
| Diagnostics.A_set_accessor_cannot_have_rest_parameter.code, | ||
| Diagnostics.A_set_accessor_must_have_exactly_one_parameter.code, | ||
| Diagnostics.An_export_declaration_can_only_be_used_in_a_module.code, | ||
| Diagnostics.An_export_declaration_cannot_have_modifiers.code, | ||
| Diagnostics.An_import_declaration_can_only_be_used_in_a_namespace_or_module.code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording seems off, and we could probably improve it and make it friendlier to JS (which doesn’t have namespaces) at the same time. I think it means that an import declaration has to be at the top level of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how it's implemented, yes. Well, it also checks for parents like namespace N or declare module "m", neither of which apply to JS.
I'll open a bug proposing to split the current implementation into 2 messages and improve the wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andrewbranch
approved these changes
Dec 9, 2021
amcasey
reviewed
Dec 9, 2021
| Diagnostics.An_object_member_cannot_be_declared_optional.code, | ||
| Diagnostics.Argument_of_dynamic_import_cannot_be_spread_element.code, | ||
| Diagnostics.Cannot_assign_to_private_method_0_Private_methods_are_not_writable.code, | ||
| Diagnostics.Cannot_redeclare_identifier_0_in_catch_clause.code, | ||
| Diagnostics.Catch_clause_variable_cannot_have_an_initializer.code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
These are the last ones that I know of. They come from calls to `grammarErrorOnFirstToken`. Fixes part of microsoft#45349 Follow-up to microsoft#47067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
These are the last ones that I know of. They come from calls to
grammarErrorOnFirstToken.Fixes part of #45349
Follow-up to #47067