| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 18 Jul 2025 18:29:22 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=277.84773,conversation_content-fragment;desc="conversation_content fragment";dur=625.4735,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=247.501959,nginx;desc="NGINX";dur=0.529878,glb;desc="GLB";dur=94.742887
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BtC7MuRkBDvHCKpJPeXwbVxM%2FG2c9Fg4FxUBP6sV6tj88%2BZLIbkHuxsUK79TKtbgShgOK6O4C4wHOOVdxNPcEQMaClYsEWmERz48MM%2FiZFcg9UG4yrzodGJOAgdU8xY8kSkO7cNqLQniPvREA9vstpkhLtPSYv7g7b1xNnnGJikpIlXab6p%2Blvxcd9XIxH06yDUal%2FbpaNPDJnvrusLUQIniryqFv2VHNs%2F7FqXmt45wwOZkARYZvfAvl3KmZZDBCjEupsHhNbLl%2FjySPIQJVQ%3D%3D--sbpiXSr6Kcm3x%2B9W--wER%2B11kJGvtCV8LGzlrrLA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.244314615.1752863361; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 18:29:21 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 18:29:21 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B660:1101E6:9C774:C262A:687A9281
Plain JS grammar errors by sandersn · Pull Request #47067 · microsoft/TypeScript · GitHub
sandersn
requested review from
andrewbranch,
amcasey and
DanielRosenwasser
and removed request for
andrewbranch
December 8, 2021 16:26
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Plain JS grammar errors #47067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Plain JS grammar errors #47067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the list in #45349 (comment), excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows up a *lot* in plain JS.
sandersn
requested review from
andrewbranch,
amcasey and
DanielRosenwasser
and removed request for
andrewbranch
|
@mjbvz You are probably interested in this as well. |
Also remove checkGrammarArguments; it's blocked entirely by the same parser error.
andrewbranch
approved these changes
Dec 8, 2021
|
From discussion in the editors meeting, VS is the only editor we looked at that itself skips semantic errors from JS. So it'll need a code change to take advantage of this PR. |
sandersn
added a commit
that referenced
this pull request
Dec 9, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Plain JS grammar errors From the list in microsoft#45349 (comment), excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows up a *lot* in plain JS. * Add grammarErrorAtPos errors Also remove checkGrammarArguments; it's blocked entirely by the same parser error.
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
These are the last ones that I know of. They come from calls to `grammarErrorOnFirstToken`. Fixes part of microsoft#45349 Follow-up to microsoft#47067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
These errors result in syntax errors in JS, making them useful for the editor to display.
From the list at #45349 (comment),
excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows
up a lot in plain JS.
Follow-up to #46816 which covers binder errors.
This list is the 56 errors out of the 184 calls to
grammarErrorOnNode, which is an arbitrary way to split up the work. I'll cover the rest of the grammar errors in a follow-up PR.Edit: I added the 7 errors from grammarErrorAtPos. This revealed that checkGrammarArguments' only check was already issued by the parser, so I deleted it with no change to the tests.