@typescript-bot pack this

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 0b02873. You can monitor the build here.

@typescript-bot pack this

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at bc91a25. You can monitor the build here.

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/108911/artifacts?artifactName=tgz&fileId=4C756A27CDE9FBA8D08572FA701057DC38B850454CF058150C36EFD3FA07C3BD02&fileName=/typescript-4.5.0-insiders.20210819.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.5.0-pr-44619-4".;

@xiaoxiangmoe that’s an option, but some people (I think reasonably) don't want to have two separate import statements for nearly every module, so we’re planning to add the specifier-level type modifier for ergonomics.

Renamed to preserveValueImports

import { type WriteFileOptions } from "fs";

Under --preserveValueImports, import "fs"; or import {} from 'fs'; or ;, which one should we compile it to?

My plan was for that to emit import {} from "fs". I think that’s the most intuitive.

import { type WriteFileOptions } from "fs";
My plan was for that to emit import {} from "fs". I think that’s the most intuitive.

That's definitely the desired behavior for "importsNotUsedAsValues": "preserve"

I assume the whole import would be elided in the case of "importsNotUsedAsValues": "remove" (though I really don't mind either way here).

Yeah, my answer was for --preserveValueImports, but I agree with that as well @robpalme.

Thank you for landing this feature in time for TypeScript 4.5! 🎉

I am super excited for the follow-on PR to introduce type-only import identifiers. Probably we would wait for that before enabling this feature, to avoid doubling up on import lines (that would occur via the addition of an import type line). IMO this all adds up to excellent progress towards explicitness and simplicity.

import { type WriteFileOptions } from "fs";

Under --preserveValueImports, import "fs"; or import {} from 'fs'; or ;, which one should we compile it to?

@xiaoxiangmoe Sorry for tagging, but I found your example might not be related in that it has nothing to do with the option/flag --preserveValueImports, which is all about value-having imports as clearly stated in OP. To conclude: An import that is used as a type was destined to be removed when
--preserveValueImports was not yet deprecated.

If you found my argument wrong, please let me know. Thanks for your reading.