You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moduleresolution description of default is changed. I could not find a way to produce line break in Diagnostics
from:
`module === AMD or UMD or System or ES6, then Classic
Otherwise Node`
to:
`module === AMD or UMD or System or ES6, then Classic, Otherwise Node`
incremental description of default is changed. This is more consistent with other descriptions.
from:
"`true` if `composite`, `false` otherwise",
to:
"`false`, unless `composite` is set"
Add plugin option to Basic Option category, before this PR, it does not belong to any category!
As we have any of to tell user candidate values, some description could be changed now. --jsx from Specify JSX code generation: 'preserve', 'react-native', 'react', 'react-jsx' or 'react-jsxdev'. to Specify JSX code generation.. The similar change is applied to target and module
I think if an option is a boolean and the default: is false or undefined or n/a, we can probably drop the 'default' and 'any of' . Might make it a bit less sparse.
There's one or two fasles typos in there
Wow there's a lot of lib options!
Maybe we should drop a few more options from the default. Let me poke some bears about that to see what others think.
Finally, I moved into new house and have spared time....
And thanks a lot to @orta 's analytics, it is really helpful.
I found the reason is about child_process, gulp runtests could finish normally, but gulp runtests-parallel cause infinite loop.
In parallel test, process.stdout.columns is undefined.
Auh, it seems a little strange for the test case of help now:
gulp runtests and gulp runtests-parallel produce different result, please see my last comment.
We use the width of terminal to give a pretty output, but the width is pretty easy to be changed, which means gulp runtests will produce a difference expected output for this case! And the test just failed...
What should we do? I feel we need to delete this case, the correspond file is runWithoutArgs.ts
The reason will be displayed to describe this comment to others. Learn more.
Alright, this is looking good to me. I'll give it till next week to give some other compiler folks to take a look over the changes but thanks a lot @ShuiRuTian! Great work.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44074