| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 04:56:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=295.788544,conversation_content-fragment;desc="conversation_content fragment";dur=560.530101,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=351.296395,nginx;desc="NGINX";dur=1.308738,glb;desc="GLB";dur=101.342738
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=yRI%2FbTq4w5qeIIwr8Z3DTfdWyv7DdMbTAXJsrOsOLhjjCXadrfACB1%2BFiQ13hOczBMC6hBR7%2BiLZ0nbk4lrAV0R5lHnhjyRiGUk6SvFfqyp%2FCk6hMVBj4FNSps19PFo6tyFqBk7lVeEW0G5%2F051ZYNKKinW90ACmSD7tTRSw5R5QqKAt90BhojxAGt%2BfX56dyGp0iAuNtuYui5bVEh78bGOAdzogguoqa2nxP7g3UFzeHvMitFIXIX%2F1nGUU%2B4cJlBJFvMjdPJv2DrwO3Z5YJg%3D%3D--u%2Br6f6IiaGpB9D%2Fb--WoYvE0jVRqPMTqXADBlDpA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.548048406.1753246594; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 04:56:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 04:56:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D9C6:26221E:39F4E6:4EE6E8:68806B82
Optimize module resolution cache for watch and editor by sheetalkamat · Pull Request #37055 · microsoft/TypeScript · GitHub
sheetalkamat
force-pushed
the
resolutionCache
branch
from
February 27, 2020 19:40
sheetalkamat
requested review from
weswigham,
amcasey,
RyanCavanaugh,
sandersn and
andrewbranch
February 28, 2020 22:33
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Optimize module resolution cache for watch and editor #37055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
force-pushed
the
resolutionCache
branch
from
0220044 to
05f6648
Compare
sheetalkamat
requested review from
weswigham,
amcasey,
RyanCavanaugh,
sandersn and
andrewbranch
|
The idea seems sensible, but I would find a high-level overview of the cache structure helpful. |
|
While investigating eslint perf with @uniqueiniquity found out that this helps with eslint when the program contains large number of files |
|
@amcasey |
amcasey
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea makes sense and the implementation looks sane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Before this change we had few issues with the resolution cache.. It only stored resolutions per file. So when something changed we had to go through map and invalidate the resolutions in each file based on what changed. Because earlier resolution was readonly only object with resolution and failed lookup locations, every resolution is distinct even when resolution in say file "/a/b/c.ts" was reused as resolution from file
/a/b/x/d.ts. The difference was that the later resolution would contain more failed lookup locations but everything else will be same. Given the number of resolutions to go through to invalidate them, we use to skip going through resolutions and just re-evaluate them when asked for if program contained more than 256 files. So there was lot of time spent in module resolution on rename of files or some such updates..This PR makes below changes:
Here are the number of resolutions for vscode source and rename action in repro
Note that ResolutionsToFile I am listing files only if number of resolutions are more than 100 to that file otherwise list gets long...
Note that vscode has 2227 files in the project
This fixes #30535