@weswigham and @DanielRosenwasser are probably the best reviewers for this.

@typescript-bot test this
@typescript-bot user test this

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks.

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks.

With 3.8 leaving beta at end of week, let's hold this until 3.9.

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

The following lines cause the error

Is it the right condition in this case?

cc @sandersn @DanielRosenwasser @weswigham

Yes, those errors are correct, and they should be fixed before merging this PR. I asked @uniqueiniquity to investigate.

Fix is #36885, thanks @uniqueiniquity for figuring it out.

@sandersn Oke, I'll wait for merge PR #36885.

OK, @a-tarasyuk can you merge from master and I'll re-run the user tests to make sure they're still good.

@typescript-bot test this
@typescript-bot user test this

Heya @sandersn, I've started to run the extended test suite on this PR at 0c06464. You can monitor the build here. It should now contribute to this PR's status checks.

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 0c06464. You can monitor the build here. It should now contribute to this PR's status checks.

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

user and RWC tests look clean
(and node 12 failure on devops is bogus)