Merge pull request #17250 from Microsoft/quickfix-jsdoc-in-ts

sandersn · web-flow · commit 7d7a06dbc268 · 2017-07-18T08:59:19.000-07:00
Quickfix jsdoc in Typescript files
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -117,6 +117,7 @@ namespace ts {
             },
             getParameterType: getTypeAtPosition,
             getReturnTypeOfSignature,
+            getNullableType,
             getNonNullableType,
             typeToTypeNode: nodeBuilder.typeToTypeNode,
             indexInfoToIndexSignatureDeclaration: nodeBuilder.indexInfoToIndexSignatureDeclaration,
@@ -9963,6 +9964,11 @@ namespace ts {
                 neverType;
         }
 
+        /**
+         * Add undefined or null or both to a type if they are missing.
+         * @param type - type to add undefined and/or null to if not present
+         * @param flags - Either TypeFlags.Undefined or TypeFlags.Null, or both
+         */
         function getNullableType(type: Type, flags: TypeFlags): Type {
             const missing = (flags & ~type.flags) & (TypeFlags.Undefined | TypeFlags.Null);
             return missing === 0 ? type :
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -2520,6 +2520,7 @@ namespace ts {
          * Returns `any` if the index is not valid.
          */
         /* @internal */ getParameterType(signature: Signature, parameterIndex: number): Type;
+        getNullableType(type: Type, flags: TypeFlags): Type;
         getNonNullableType(type: Type): Type;
 
         /** Note that the resulting nodes cannot be checked. */
diff --git a/src/services/codefixes/disableJsDiagnostics.ts b/src/services/codefixes/disableJsDiagnostics.ts
@@ -32,7 +32,7 @@ namespace ts.codefix {
             }
         }
 
-        // If all fails, add an extra new line immediatlly before the error span.
+        // If all fails, add an extra new line immediately before the error span.
         return {
             span: { start: position, length: 0 },
             newText: `${position === startPosition ? "" : newLineCharacter}// @ts-ignore${newLineCharacter}`
@@ -67,4 +67,4 @@ namespace ts.codefix {
             }]
         }];
     }
-}
+}
diff --git a/src/services/codefixes/fixJSDocTypes.ts b/src/services/codefixes/fixJSDocTypes.ts
@@ -0,0 +1,40 @@
+/* @internal */
+namespace ts.codefix {
+    registerCodeFix({
+        errorCodes: [Diagnostics.JSDoc_types_can_only_be_used_inside_documentation_comments.code],
+        getCodeActions: getActionsForJSDocTypes
+    });
+
+    function getActionsForJSDocTypes(context: CodeFixContext): CodeAction[] | undefined {
+        const sourceFile = context.sourceFile;
+        const node = getTokenAtPosition(sourceFile, context.span.start, /*includeJsDocComment*/ false);
+        const decl = ts.findAncestor(node, n => n.kind === SyntaxKind.VariableDeclaration);
+        if (!decl) return;
+        const checker = context.program.getTypeChecker();
+
+        const jsdocType = (decl as VariableDeclaration).type;
+        const original = getTextOfNode(jsdocType);
+        const type = checker.getTypeFromTypeNode(jsdocType);
+        const actions = [createAction(jsdocType, sourceFile.fileName, original, checker.typeToString(type, /*enclosingDeclaration*/ undefined, TypeFormatFlags.NoTruncation))];
+        if (jsdocType.kind === SyntaxKind.JSDocNullableType) {
+            // for nullable types, suggest the flow-compatible `T | null | undefined`
+            // in addition to the jsdoc/closure-compatible `T | null`
+            const replacementWithUndefined = checker.typeToString(checker.getNullableType(type, TypeFlags.Undefined), /*enclosingDeclaration*/ undefined, TypeFormatFlags.NoTruncation);
+            actions.push(createAction(jsdocType, sourceFile.fileName, original, replacementWithUndefined));
+        }
+        return actions;
+    }
+
+    function createAction(declaration: TypeNode, fileName: string, original: string, replacement: string): CodeAction {
+        return {
+            description: formatStringFromArgs(getLocaleSpecificMessage(Diagnostics.Change_0_to_1), [original, replacement]),
+            changes: [{
+                fileName,
+                textChanges: [{
+                    span: { start: declaration.getStart(), length: declaration.getWidth() },
+                    newText: replacement
+                }]
+            }],
+        };
+    }
+}
diff --git a/src/services/codefixes/fixes.ts b/src/services/codefixes/fixes.ts
@@ -7,6 +7,7 @@
 /// <reference path="fixExtendsInterfaceBecomesImplements.ts" />
 /// <reference path="fixForgottenThisPropertyAccess.ts" />
 /// <reference path='fixUnusedIdentifier.ts' />
+/// <reference path='fixJSDocTypes.ts' />
 /// <reference path='importFixes.ts' />
 /// <reference path='disableJsDiagnostics.ts' />
 /// <reference path='helpers.ts' />
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax1.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax1.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|?|] = 12;
+
+verify.rangeAfterCodeFix("any");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax2.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax2.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|*|] = 12;
+
+verify.rangeAfterCodeFix("any");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax3.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax3.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|......number[][]|] = 12;
+
+verify.rangeAfterCodeFix("number[][][][]");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax4.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax4.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|Array.<number>|] = 12;
+
+verify.rangeAfterCodeFix("number[]");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax5.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax5.ts
@@ -0,0 +1,5 @@
+// @strict: true
+/// <reference path='fourslash.ts' />
+//// var x: [|?number|] = 12;
+
+verify.rangeAfterCodeFix("number | null", /*includeWhiteSpace*/ false, /*errorCode*/ 8020, 0);
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax6.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax6.ts
@@ -0,0 +1,5 @@
+// @strict: true
+/// <reference path='fourslash.ts' />
+//// var x: [|number?|] = 12;
+
+verify.rangeAfterCodeFix("number | null | undefined", /*includeWhiteSpace*/ undefined, /*errorCode*/ undefined, 1);
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax7.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax7.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|!number|] = 12;
+
+verify.rangeAfterCodeFix("number");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax8.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax8.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|function(this: number, number): string|] = 12;
+
+verify.rangeAfterCodeFix("(this: number, arg1: number) => string");
diff --git a/tests/cases/fourslash/codeFixChangeJSDocSyntax9.ts b/tests/cases/fourslash/codeFixChangeJSDocSyntax9.ts
@@ -0,0 +1,4 @@
+/// <reference path='fourslash.ts' />
+//// var x: [|function(new: number)|] = 12;
+
+verify.rangeAfterCodeFix("new () => number");

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ namespace ts.codefix {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`
`35`		`- // If all fails, add an extra new line immediatlly before the error span.`
	`35`	`+ // If all fails, add an extra new line immediately before the error span.`
`36`	`36`	`return {`
`37`	`37`	`span: { start: position, length: 0 },`
`38`	`38`	newText: `${position === startPosition ? "" : newLineCharacter}// @ts-ignore${newLineCharacter}`
`@@ -67,4 +67,4 @@ namespace ts.codefix {`
`67`	`67`	`}]`
`68`	`68`	`}];`
`69`	`69`	`}`
`70`		`-}`
	`70`	`+}`