CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 14:50:25 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/microsoft/TypeScript.git
etag: W/"f8aa1fa939ac2567375c0128ef0cffb0"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=qtaR4xUpiaTeufP6SJyoQP%2FgtU5vVowWqp251%2FEZUg6ACB34gmYwW4u%2B4aSIvwxK8hECCHILKkEDXr3xVNNYVTkjkwQiCsnWl8ic9nvX7jbLWjcD9W%2Fznv6MLLzahSf9b9ijDUpi%2B%2FBRChWUJr6Gvp3m1qW5gWMaaBYcWSDsjd2pT3Nqci8VXhbaY0jJvA%2FRIRX%2F3dR0oodEruUx9IWsTVgeI9nikEGfdREwKZtES%2BC%2BsCri8fMCyBM1dMfI7Zpk0ofn7%2FeHxYOMcwy0ZqpKhw%3D%3D--liQ5EG8HysLoZ%2B%2BD--IqX7xsIgR4uq4mtAKiZQLA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.884527083.1753282223; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 14:50:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 14:50:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CB32:26221E:D7AE86:FF1FDE:6880F6AF
Forbid unused property renaming in destructuring binding in function … · microsoft/TypeScript@29dffc3 · GitHub
Dismiss banner
Copy file name to clipboardExpand all lines: src/compiler/diagnosticMessages.json
Copy file name to clipboardExpand all lines: src/compiler/transformers/declarations.ts
Copy file name to clipboardExpand all lines: tests/baselines/reference/contextuallyTypedBindingInitializerNegative.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationEmitBindingPatterns.js
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationEmitBindingPatterns.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationsAndAssignments.types
Copy file name to clipboard
Copy file name to clipboardExpand all lines: tests/baselines/reference/destructuringInFunctionType.js
Copy file name to clipboardExpand all lines: tests/baselines/reference/destructuringInFunctionType.types
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit 29dffc3
authored
Forbid unused property renaming in destructuring binding in function types (#41044)
* Forbid renaming a propertyin function type parameters
* add tests
* Remove renaming from declaration output
* accept baseline
* accept baseline
* renew tests (not very right now)
* get correct result
* update diagnostic text
* accept baseline
* add declaration emit test
* fix declaration emit
* fix formatting
* revert unnecessary change
* accept baseline
* extend tests
* Revert "revert unnecessary change"
This reverts commit 17a29ff.
* accept baseline
* Rename and refactor potentialAlways... stuff
* add non-identifier names
* extend check to non-identifier original property names
* update diagnostic message
* add related span
* accept baseline
* add symbol-keyed test case
* oops?
* workaround for unstable test
* fix suggested name
* add comment about non-identifier property names
* simplify isReferenced check
* accept baseline
* move it one step further1 parent dbab6eb commit 29dffc3Copy full SHA for 29dffc3
File tree
Expand file treeCollapse file tree
41 files changed
+1691
-73
lines changedFilter options
- src/compiler
- transformers
- tests
- baselines/reference
- cases/compiler
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Expand file treeCollapse file tree
41 files changed
+1691
-73
lines changed+55-9Lines changed: 55 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1015 | 1015 |
| |
1016 | 1016 |
| |
1017 | 1017 |
| |
| 1018 | + | |
1018 | 1019 |
| |
1019 | 1020 |
| |
1020 | 1021 |
| |
| |||
5945 | 5946 |
| |
5946 | 5947 |
| |
5947 | 5948 |
| |
5948 |
| - | |
5949 |
| - | |
| 5949 | + | |
| 5950 | + | |
5950 | 5951 |
| |
5951 | 5952 |
| |
5952 | 5953 |
| |
5953 |
| - | |
| 5954 | + | |
5954 | 5955 |
| |
5955 |
| - | |
5956 |
| - | |
5957 |
| - | |
5958 |
| - | |
5959 |
| - | |
5960 |
| - | |
| 5956 | + | |
| 5957 | + | |
| 5958 | + | |
| 5959 | + | |
| 5960 | + | |
| 5961 | + | |
| 5962 | + | |
| 5963 | + | |
| 5964 | + | |
| 5965 | + | |
| 5966 | + | |
| 5967 | + | |
| 5968 | + | |
| 5969 | + | |
| 5970 | + | |
| 5971 | + | |
5961 | 5972 |
| |
5962 | 5973 |
| |
5963 | 5974 |
| |
| |||
37432 | 37443 |
| |
37433 | 37444 |
| |
37434 | 37445 |
| |
| 37446 | + | |
| 37447 | + | |
| 37448 | + | |
| 37449 | + | |
| 37450 | + | |
| 37451 | + | |
| 37452 | + | |
| 37453 | + | |
| 37454 | + | |
| 37455 | + | |
| 37456 | + | |
| 37457 | + | |
| 37458 | + | |
| 37459 | + | |
| 37460 | + | |
| 37461 | + | |
| 37462 | + | |
| 37463 | + | |
37435 | 37464 |
| |
37436 | 37465 |
| |
37437 | 37466 |
| |
| |||
37773 | 37802 |
| |
37774 | 37803 |
| |
37775 | 37804 |
| |
| 37805 | + | |
| 37806 | + | |
| 37807 | + | |
| 37808 | + | |
| 37809 | + | |
| 37810 | + | |
| 37811 | + | |
| 37812 | + | |
| 37813 | + | |
| 37814 | + | |
| 37815 | + | |
| 37816 | + | |
| 37817 | + | |
37776 | 37818 |
| |
37777 | 37819 |
| |
37778 | 37820 |
| |
| |||
41617 | 41659 |
| |
41618 | 41660 |
| |
41619 | 41661 |
| |
| 41662 | + | |
41620 | 41663 |
| |
41621 | 41664 |
| |
41622 | 41665 |
| |
| |||
41636 | 41679 |
| |
41637 | 41680 |
| |
41638 | 41681 |
| |
| 41682 | + | |
| 41683 | + | |
| 41684 | + | |
41639 | 41685 |
| |
41640 | 41686 |
| |
41641 | 41687 |
| |
|
src/compiler/diagnosticMessages.json
Copy file name to clipboardExpand all lines: src/compiler/diagnosticMessages.json+8Lines changed: 8 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3487 | 3487 |
| |
3488 | 3488 |
| |
3489 | 3489 |
| |
| 3490 | + | |
| 3491 | + | |
| 3492 | + | |
| 3493 | + | |
| 3494 | + | |
| 3495 | + | |
| 3496 | + | |
| 3497 | + | |
3490 | 3498 |
| |
3491 | 3499 |
| |
3492 | 3500 |
| |
|
src/compiler/transformers/declarations.ts
Copy file name to clipboardExpand all lines: src/compiler/transformers/declarations.ts+19-3Lines changed: 19 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
453 | 453 |
| |
454 | 454 |
| |
455 | 455 |
| |
456 |
| - | |
| 456 | + | |
457 | 457 |
| |
458 | 458 |
| |
459 | 459 |
| |
| |||
471 | 471 |
| |
472 | 472 |
| |
473 | 473 |
| |
474 |
| - | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
475 | 491 |
| |
476 | 492 |
| |
477 | 493 |
| |
| |||
485 | 501 |
| |
486 | 502 |
| |
487 | 503 |
| |
488 |
| - | |
| 504 | + | |
489 | 505 |
| |
490 | 506 |
| |
491 | 507 |
| |
|
tests/baselines/reference/contextuallyTypedBindingInitializerNegative.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/contextuallyTypedBindingInitializerNegative.types+2-2Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
5 | 5 |
| |
6 | 6 |
| |
7 | 7 |
| |
8 |
| - | |
| 8 | + | |
9 | 9 |
| |
10 | 10 |
| |
11 | 11 |
| |
| |||
32 | 32 |
| |
33 | 33 |
| |
34 | 34 |
| |
35 |
| - | |
| 35 | + | |
36 | 36 |
| |
37 | 37 |
| |
38 | 38 |
| |
|
tests/baselines/reference/declarationEmitBindingPatterns.js
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationEmitBindingPatterns.js+1-1Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
18 | 18 |
| |
19 | 19 |
| |
20 | 20 |
| |
21 |
| - | |
| 21 | + | |
22 | 22 |
| |
23 | 23 |
| |
24 | 24 |
| |
|
tests/baselines/reference/declarationEmitBindingPatterns.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationEmitBindingPatterns.types+2-2Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 | 1 |
| |
2 | 2 |
| |
3 |
| - | |
4 |
| - | |
| 3 | + | |
| 4 | + | |
5 | 5 |
| |
6 | 6 |
| |
7 | 7 |
| |
|
tests/baselines/reference/declarationsAndAssignments.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/declarationsAndAssignments.types+4-4Lines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
417 | 417 |
| |
418 | 418 |
| |
419 | 419 |
| |
420 |
| - | |
| 420 | + | |
421 | 421 |
| |
422 | 422 |
| |
423 | 423 |
| |
| |||
438 | 438 |
| |
439 | 439 |
| |
440 | 440 |
| |
441 |
| - | |
| 441 | + | |
442 | 442 |
| |
443 | 443 |
| |
444 | 444 |
| |
| |||
451 | 451 |
| |
452 | 452 |
| |
453 | 453 |
| |
454 |
| - | |
| 454 | + | |
455 | 455 |
| |
456 | 456 |
| |
457 | 457 |
| |
| |||
462 | 462 |
| |
463 | 463 |
| |
464 | 464 |
| |
465 |
| - | |
| 465 | + | |
466 | 466 |
| |
467 | 467 |
| |
468 | 468 |
| |
|
tests/baselines/reference/destructuringInFunctionType.errors.txt
Copy file name to clipboard+32Lines changed: 32 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + |
tests/baselines/reference/destructuringInFunctionType.js
Copy file name to clipboardExpand all lines: tests/baselines/reference/destructuringInFunctionType.js+1-1Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
52 | 52 |
| |
53 | 53 |
| |
54 | 54 |
| |
55 |
| - | |
| 55 | + | |
56 | 56 |
| |
57 | 57 |
| |
58 | 58 |
| |
|
tests/baselines/reference/destructuringInFunctionType.types
Copy file name to clipboardExpand all lines: tests/baselines/reference/destructuringInFunctionType.types+1-1Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
31 | 31 |
| |
32 | 32 |
| |
33 | 33 |
| |
34 |
| - | |
| 34 | + | |
35 | 35 |
| |
36 | 36 |
| |
37 | 37 |
| |
|
You can’t perform that action at this time.
0 commit comments